public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Tamir Duberstein <tamird@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] printf: mark errptr() noinline
Date: Wed, 8 Apr 2026 09:24:58 +0200	[thread overview]
Message-ID: <adYCyvTlIoTdnKcL@pathway.suse.cz> (raw)
In-Reply-To: <20260407160809.48d5fe2a@pumpkin>

On Tue 2026-04-07 16:08:09, David Laight wrote:
> On Mon, 6 Apr 2026 12:32:32 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Mon, 6 Apr 2026 11:21:39 -0400
> > Tamir Duberstein <tamird@kernel.org> wrote:
> > 
> > > Thanks Steve. IMO that is a very big hammer and not warranted in this
> > > case. There's been talk of encouraging distros to enable CONFIG_KUNIT
> > > by default [0], which would probably interact poorly with the change
> > > you propose.
> > >   
> > 
> > Branch profiling is really just a niche that is enabled specifically for
> > seeing all branches taken in the kernel. It hooks to all "if" statements!
> > As you can imagine, it causes a rather large overhead in performance.
> > 
> > This option is only used by developers doing special analysis of their code
> > (namely me ;-).
> 
> Is there any way to stop randconfig picking up options like these?
> It is rather a waste of brain-cycles trying to fix them.
> If you want the option to test a specific bit of code it is easy to
> hack/disable any problematic parts.
> 
> Even having the KASAN/KMSAN code compiled into allmodconfig is a PITA
> when you are trying to check that code compiles to something sensible.

This does not look like a good idea. KASAN/KMSAN are very useful
features. People will want to keep them working. Removing them from
randconfig would just postpone detection of the problem. We would
need to deal with it sooner or later anyway.

Best Regards,
Petr

  reply	other threads:[~2026-04-08  7:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-05 17:31 [PATCH] printf: mark errptr() noinline Tamir Duberstein
2026-04-05 18:17 ` Greg KH
2026-04-06 15:15 ` Steven Rostedt
2026-04-06 15:21   ` Tamir Duberstein
2026-04-06 16:32     ` Steven Rostedt
2026-04-07 11:27       ` Petr Mladek
2026-04-07 13:34         ` Tamir Duberstein
2026-04-08  7:16           ` Petr Mladek
2026-04-08 10:18             ` Tamir Duberstein
2026-04-08 12:28               ` [PATCH v2] printf: Compile the kunit test with DISABLE_BRANCH_PROFILING Petr Mladek
2026-04-08 12:42                 ` Tamir Duberstein
2026-04-07 15:08       ` [PATCH] printf: mark errptr() noinline David Laight
2026-04-08  7:24         ` Petr Mladek [this message]
2026-04-08  9:04           ` David Laight
2026-04-08 11:29             ` Andy Shevchenko
2026-04-08 12:12               ` David Laight
2026-04-06 16:40 ` Tamir Duberstein
2026-04-07 10:31 ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adYCyvTlIoTdnKcL@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=david.laight.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=lkp@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=stable@vger.kernel.org \
    --cc=tamird@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox