From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE22938236A; Wed, 8 Apr 2026 07:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775633642; cv=none; b=tA0xDuKew+Cki2i9lA493Hqa8wnAdSZVBCjdQhGemmAJ07nQQochjliQP6fDf6qMR9/ArrkRxlwFaYk1i5478trcWDekehubAfY4H4Zn93F8+KRaOaDiivkeSdBxKeb3Wv5VrmflPWRIivWB0e3p8zcuG6tKMYa9T5RRJqdb2u8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775633642; c=relaxed/simple; bh=Shv2ZRsbtiCbvwYvbjPxGTs2BTFskGyrLs7Tu0GzFl8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sqYsoOOJAJrfdodq9a4dXKh2GJ4FRypDGrdZ6+vhf5y1SlRBrQI3EWgULibhtL3L/XPhiWAbAv0/tcKzCdV07sXpto/ql2s0GjHvgZCWlzPrYYEhTds/4IVyHXHfG30QfEM53o1LW9hCMtFRlDLvxCgE5ixjZTEYjPJpUIgL9vY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W4bPo0lw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W4bPo0lw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BA1CC2BCB0; Wed, 8 Apr 2026 07:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775633642; bh=Shv2ZRsbtiCbvwYvbjPxGTs2BTFskGyrLs7Tu0GzFl8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W4bPo0lwtp7qZ05/+tHhrfjLwUf4Zh8RtDKl1XHJgv/55tNdxoxRIt+3azELtbKV4 /ztUcPtI/BbhF2FjjmtyHV2VR9sEnaiIT8jH7qZUxuo93Z9lk7RiTdBxtjH+jnVr5W Pb4GZCvvu7ao20Yhts8ZK1wgmbRcT2wf2Pazp+x5YlnxdUxLXy33dt1/nPUr2RR1Ry Rv5neZeiAPoeQsxSRFOQiC+kwVjIXUpFYw5Lgs/cSjrKMzbrF0KzTkjk6jViJX/dzW 3xP3pxD0qFW4KySMbK0YoGUc0q4GsVNTm9+KVizVxTCccNxhkfiDQQspQf+PPXaqbM GOKkIUllbqYZQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wANQG-000000001Ol-1FIu; Wed, 08 Apr 2026 09:34:00 +0200 Date: Wed, 8 Apr 2026 09:34:00 +0200 From: Johan Hovold To: Doug Anderson Cc: Mark Brown , Liam Girdwood , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sebastian Reichel Subject: Re: [PATCH 2/2] regulator: rk808: fix OF node reference imbalance Message-ID: References: <20260407094156.2573027-1-johan@kernel.org> <20260407094156.2573027-3-johan@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Apr 07, 2026 at 05:57:06PM -0700, Doug Anderson wrote: > On Tue, Apr 7, 2026 at 2:42 AM Johan Hovold wrote: > > > > The driver reuses the OF node of the parent multi-function device but > > fails to take another reference to balance the one dropped by the > > platform bus code when unbinding the MFD and deregistering the child > > devices. > > > > Fix this by using the intended helper for reusing OF nodes. > > > > Fixes: 5111c931f36c ("regulator: rk808: cleanup parent device usage") > > I don't think this is quite the right "Fixes". Even before that > commit, the driver copied the parent's "of_node" and still set > "of_node_reused". > > The first place I see the parent's "of_node" being copied is actually > commit 647e57351f8e ("regulator: rk808: reduce 'struct rk808' usage"). > "of_node_reused" is first set in commit 1b9e86d445a0 ("regulator: > rk808: fix asynchronous probing"), but really that should have been > set in the beginning anyway... Indeed, thanks for catching that. I've just sent a v2 of the series with the correct tag and that includes all of the regulator fixes that unfortunately ended up being being spread over three series. Johan