From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6751222DFA7; Mon, 7 Jul 2025 17:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751911196; cv=none; b=NryLfRp60hLi27+Q0GxQ2oIXEkoeXMFi1vILR9Ml/ixszMFXr5EOlZv/2cPD5wRdfqzUFGdw+Tfj+34phAM43VAV4jqE8KEBoHK6qbSltjMj4k38RiKzoJOO8Iw+UEJloma68B2cSz/THVmTnjYuPqTyYu7S22QHSaLqZX85dI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751911196; c=relaxed/simple; bh=h9zvtpIR/kBrqJ1m+JHFjDXxih1BE7QfRuvA9R9sl6s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ImjG0hW5NjEa/3qpsFr3GXoWehyJQ77OBRWr+3GY/nF3hSssaw841oRVf6iA09ALcC1inlV5J2Z2NDzcFBhJ9MK5HhOKSnBwdzbv0TsAJVBFt3LglWtGWMbi+nKPHUa2gmSwymCJg5D8AipydFZlZhhfvNkn26VlZ3LxfAGVf+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=Juecdsl1; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="Juecdsl1" Received: from [10.137.184.60] (unknown [131.107.160.188]) by linux.microsoft.com (Postfix) with ESMTPSA id D1D5F2054680; Mon, 7 Jul 2025 10:59:54 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D1D5F2054680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1751911194; bh=zeLAABhUJntnMN2QCq43FYeskbX+YlDSGreNuuisNvA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Juecdsl1txvCzZfEQkRt9uMv4iD/sqsTLX/Z4Zocf1oI/sEohn9j7DO2um+iuzkVW u6o7vh5phHfXHeLAu1JA5p4xqBQ8r6rK2WAyhR11fjtzCU88jBJ9K9s5Gm6zuD52yL kedkEmAL/LQxnsCX/alPbUhYJmbfZssgoP6GfWiY= Message-ID: Date: Mon, 7 Jul 2025 10:59:54 -0700 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] Drivers: hv: Select CONFIG_SYSFB only if EFI is enabled To: mhklinux@outlook.com Cc: linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, stable@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, deller@gmx.de, javierm@redhat.com, arnd@arndb.de References: <20250613230059.380483-1-mhklinux@outlook.com> Content-Language: en-US From: Roman Kisel In-Reply-To: <20250613230059.380483-1-mhklinux@outlook.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/13/2025 4:00 PM, mhkelley58@gmail.com wrote: > From: Michael Kelley > > Commit 96959283a58d ("Drivers: hv: Always select CONFIG_SYSFB > for Hyper-V guests") selects CONFIG_SYSFB for Hyper-V guests > so that screen_info is available to the VMBus driver to get > the location of the framebuffer in Generation 2 VMs. However, > if CONFIG_HYPERV is enabled but CONFIG_EFI is not, a kernel > link error results in ARM64 builds because screen_info is > provided by the EFI firmware interface. While configuring > an ARM64 Hyper-V guest without EFI isn't useful since EFI is > required to boot, the configuration is still possible and > the link error should be prevented. > > Fix this by making the selection of CONFIG_SYSFB conditional > on CONFIG_EFI being defined. For Generation 1 VMs on x86/x64, > which don't use EFI, the additional condition is OK because > such VMs get the framebuffer information via a mechanism > that doesn't use screen_info. > [...] LGTM. Reviewed-by: Roman Kisel -- Thank you, Roman