From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28B4B373BEE for ; Wed, 15 Apr 2026 22:20:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291635; cv=none; b=oIK18oB7Kc2/VFlTwR0AgP6JrVebY7dX4TxC/fDUuE1to1EX25KlH8YsY0YqpBLMxUs0fSS3f1N1SGqUkaGQT3bdZvPKoqJqXyYMJCLppyfYTQkcsBOxIDXfXoVZLjs6dHgF+2at7xc4LWQFobME0hOEYddEVH43pXParBSxCR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291635; c=relaxed/simple; bh=vdpdh0xkIajBHZM7qoM+xUEgxrphiImhs+GqNY7hsgk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=L5rOCbgfFbKry01MLDSOnHKcFkuOQRWkTIcftC/VdbUc7JJ0cZ7e89tEanc+BApCmAvBNIAM5P8HYOf/og/3ETxvWIKCGx60r9FI7iYv0qD3eACwsJiMBGl1ZlnTWQC34JWulsX5z7lBl8Cezr5pWTmldMRiwhiB/HqGJWFQs/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=amVG5gwp; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="amVG5gwp" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-35842aa350fso13800175a91.0 for ; Wed, 15 Apr 2026 15:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776291633; x=1776896433; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QToygMVPGVk7KubMavoRHu5zoGCxschPTOHOfHs+CAE=; b=amVG5gwpo6T9HKLFuKS2ujxjnEvTvlN+UV61Mls7/1FTaNQ8TSnAtjR2rGYxz7k2yo xNhEVp4rPEP1Yy6CzviCV8mKAIzImtYeJB7nhwmRxOg7uC7+4g+wbkAOVhPja0WHjETq g0+6Im6SdIrcuymovcPmXygmTJWEM2l5NvMNtfcEJWVI7MRe77n7vdvrlgaqT/oeY1pw /oYhbXO+6TTq1TRr/w45JCns5MsvxAXhWLqJ2N096wBXmEt8dbvPDXXUzowqIRBYoQQG Q2mLuyGguGGif2gmYViUVgZFG3GMbhdKmj2RLjIblkNaxPMORPhzvxCJSVxVjM9C3NbO 3hug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291633; x=1776896433; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QToygMVPGVk7KubMavoRHu5zoGCxschPTOHOfHs+CAE=; b=bMqJP68tcEJJlQH/LCW5cNeuIJ4ki81PHkzav0inxs4lOqpRGN8RnjMWfGKZOZmfnv fgrp47jiZ/Hq8bQJ5sUmGT94H4L39pGYXciuUA8Pu3HR020wiSJ0UKCpcm8M9YbYvhGB N8FhXkYvedcrq5zh+AQOInoN8h76wZ5sn//8UoIpLsH/wZWSWV4j5ALP+nW8yvSb64cq nWLI8fRS+VXBni3iv3r2b1nDwcXrFR3Nv3d2es7clZjjCcWMdSL4+8O9mNrm5VkHB25v Juswk8rTM9yFVM52v+fcs33s8OtgUmhXVXBs1A1musNGP2c+hg284BL08JAof0MnDzbb 9ZtA== X-Gm-Message-State: AOJu0Yzm0ZsL2eU4C+HORsZ/aPqmagqZ8mN5AEnCgheBtK/GhRuWpM5h 41Ui9ye8RSqd3uWotwiJJAObRXcH9qtfEO4l0DLWWOD2GXhO28RWypT6wtEGD3Np25J0XfUEZol dPhH0xA== X-Received: from pgbdp8.prod.google.com ([2002:a05:6a02:f08:b0:c74:2046:ade]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:e292:b0:39b:8545:f0d with SMTP id adf61e73a8af0-39fe4064a87mr26156990637.51.1776291633300; Wed, 15 Apr 2026 15:20:33 -0700 (PDT) Date: Wed, 15 Apr 2026 15:20:32 -0700 In-Reply-To: <20260413125149.2876836-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <2026041316-tribunal-pendant-dc80@gregkh> <20260413125149.2876836-1-sashal@kernel.org> Message-ID: Subject: Re: [PATCH 6.19.y 1/2] KVM: Remove subtle "struct kvm_stats_desc" pseudo-overlay From: Sean Christopherson To: Sasha Levin Cc: stable@vger.kernel.org, "Gustavo A. R. Silva" , Marc Zyngier , Christian Borntraeger , Anup Patel , Bibo Mao Content-Type: text/plain; charset="us-ascii" On Mon, Apr 13, 2026, Sasha Levin wrote: > From: Sean Christopherson > > [ Upstream commit da142f3d373a6ddaca0119615a8db2175ddc4121 ] > > Remove KVM's internal pseudo-overlay of kvm_stats_desc, which subtly > aliases the flexible name[] in the uAPI definition with a fixed-size array > of the same name. The unusual embedded structure results in compiler > warnings due to -Wflex-array-member-not-at-end, and also necessitates an > extra level of dereferencing in KVM. To avoid the "overlay", define the > uAPI structure to have a fixed-size name when building for the kernel. > > Opportunistically clean up the indentation for the stats macros, and > replace spaces with tabs. > > No functional change intended. > > Reported-by: Gustavo A. R. Silva > Closes: https://lore.kernel.org/all/aPfNKRpLfhmhYqfP@kspp > Acked-by: Marc Zyngier > Acked-by: Christian Borntraeger > [..] > Acked-by: Anup Patel > Reviewed-by: Bibo Mao > Acked-by: Gustavo A. R. Silva > Link: https://patch.msgid.link/20251205232655.445294-1-seanjc@google.com > Signed-off-by: Sean Christopherson > Stable-dep-of: 2619da73bb2f ("KVM: x86: Use __DECLARE_FLEX_ARRAY() for UAPI structures with VLAs") > Signed-off-by: Sasha Levin > --- Acked-by: Sean Christopherson