From: Johan Hovold <johan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH] spi: mpc52xx: fix use-after-free on registration failure
Date: Thu, 23 Apr 2026 10:00:54 +0200 [thread overview]
Message-ID: <aenRtqDVr-ACBeG9@hovoldconsulting.com> (raw)
In-Reply-To: <9230f719-2c5f-40d6-9486-612c8fec311a@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Wed, Apr 22, 2026 at 06:12:58PM +0100, Mark Brown wrote:
> On Wed, Apr 22, 2026 at 05:41:32PM +0200, Johan Hovold wrote:
> > On Tue, Apr 21, 2026 at 02:58:00PM +0200, Johan Hovold wrote:
> > > Make sure to disable and free the interrupts in case controller
> > > registration fails to avoid a potential use-after-free and resource
> > > leak.
>
> > This one will need another spin to address some further pre-existing
> > issues flagged by Sashiko.
>
> Please do an incremental change, it's already in CI with some merges on
> top of it.
False alarm. Sashiko flagged the freeing of interrupt zero as triggering
a warning, but that should only be the case on x86.
I've sent a clean up patch for this here:
https://lore.kernel.org/r/20260423075801.2252318-1-johan@kernel.org
Johan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]
prev parent reply other threads:[~2026-04-23 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 12:58 [PATCH] spi: mpc52xx: fix use-after-free on registration failure Johan Hovold
2026-04-22 12:43 ` Mark Brown
2026-04-22 15:41 ` Johan Hovold
2026-04-22 17:12 ` Mark Brown
2026-04-23 8:00 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aenRtqDVr-ACBeG9@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=broonie@kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox