From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12F4A285061; Wed, 20 May 2026 01:15:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779239757; cv=none; b=kvrKn+W999216CiHHQvP6z/CVhQ3cJKUAQxSfgRRpbqjiuGsO3+MrxulPxwSpaxK9JxcLE/z24O/2FEfhcDn1jQZGk2joYJjUBo3v8E6F2ZdcuwrTpVVvvZgEDQQMcWrzHFzQdMDRWG7wMqlX2x5aNDTWaYEdzaFKCHCebSKtgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779239757; c=relaxed/simple; bh=iMyq01rBZERRH9e8tzJEI2hI9k/rW8wFOEsDjxpIXI0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aMUpdsLub/E60Qk15igldvsrS+oQoSATHWsv/rpL97Na9t5uoujCQYfB3ghxQFm/CDi3slW6XcNtITvHWyCCqfZ1CiPX1LADVdeJpWOHoIvz+aqIBiryMBk1SO6tm392JafHNTubfJ0h5+STFmTczCu/PveQt8tVUE25lgR7hjY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NqOkAmqJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NqOkAmqJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 685651F000E9; Wed, 20 May 2026 01:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779239755; bh=ZCaU6+VJbWf/ON+TfBNoaRwtJMxXOyq2Ap1E51+Y6vk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=NqOkAmqJtSRAFLPaCEgDqX5+u0T8Nup7ZJN0BNuJoENp2sYDl2ZwRm2yDioS8GJ9U nWzX/OCvD1KsoXWD1frTukwLHJLI5IbOSBotl50soKbliEXC+CSnS7KMZSc9YNNJdd gIe+lu1IyKyiNJHJ4la0B6rjXDDTm/+aOmrD7d0VB5qYoKCno2py3I0lSF0CO/xDtB 1CE2W0/Cv/fRlO9tfFPupkf5oLJ6Qe18HenARUtIEQr43ScwAkuwx+gJ9O+yW99usn t7sQcLQeo7botT90GNMWSdsCphAt0Vv201+YSWVXMVCXzM0SjoHv4Mrt7jpREXD8E5 6u3yuNt1YMYXQ== Date: Tue, 19 May 2026 21:15:54 -0400 From: Sasha Levin To: gregkh@linuxfoundation.org, stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Ranjani Sridharan , Bard Liao , Liam Girdwood , Mateusz Redzynia , Peter Ujfalusi , Mark Brown , Alva Lan Subject: Re: [PATCH 6.6.y] ASoC: SOF: Intel: hda: Fix NULL pointer dereference Message-ID: References: <20260519220508.reply-0006@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260519220508.reply-0006@kernel.org> On Tue, May 19, 2026 at 08:54:19PM -0400, Sasha Levin wrote: >On Tue, May 19, 2026 at 06:44:10PM +0800, Alva Lan wrote: >> From: Ranjani Sridharan >> >> [ Upstream commit 16c589567a956d46a7c1363af3f64de3d420af20 ] >> >> If there's a mismatch between the DAI links in the machine driver and >> the topology, it is possible that the playback/capture widget is not >> set, especially in the case of loopback capture for echo reference >> where we use the dummy DAI link. Return the error when the widget is not >> set to avoid a null pointer dereference like below when the topology is >> broken. >[...] >> [ Minor context conflict resolved. ] >> Signed-off-by: Alva Lan > >Queued for 6.6, thanks. Ugh... This backport is missing the !swidget NULL check that the upstream commit also adds. Upstream 16c589567a95 adds two checks in hda_dai_get_ops(): one for !w and one for !swidget. Your patch only adds the !w check, so the later "sdai = swidget->private" still crashes when w is non-NULL but w->dobj.private is NULL. I'm going to drop it for now. -- Thanks, Sasha