From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 705B32727FD for ; Sun, 10 May 2026 16:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778431725; cv=none; b=RhKAAJ2rZArL3sXZER7S+lZEEuMF7I/es5BUDBqR+gBBKiI9KB/1i+HzZUC2Sy5nczkWVGM8We10kqNL+YV+ei7Ss/oHCHDSm5tDykZcZfey4i/uj8asnb5qiZJT46FCb896Jr2da83pj39P9uzpn1VMNfgFiMJkrLs5lWGjuas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778431725; c=relaxed/simple; bh=SaRV1teEcYuK3pDM4kjkaHnrIO71cSDF/PbaaMnoYTc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pN5sJxTG2JtJZZOhPsqNs8eFE0//qIcnzA/wLjuMzrMVqXv/aHFQyd/hcKECyFFKpb/tqyTiL4xTF59WEmNYeOEmQDrlAc3hlERS1jGoy37/aOKwFgHE+TISC69GkpUZ1ZbMCmmWsRck93IOQjo+PTSJG9X6vgD1jszLlV6p59Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JaGaJsVR; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JaGaJsVR" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2b941cd869cso20546135ad.1 for ; Sun, 10 May 2026 09:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778431724; x=1779036524; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eArBLCmYCsffvtaqVgZP4cXQn2AO6g/xQoo/oq6NlGs=; b=JaGaJsVRMIl2RcXQ5IAKLq1GFZwBXqvT93Ih88vKuq3hbLbu0apXjA4jhNUyEBj7rh mfyj4XvmgZ15Cr9LHVW06Lr+LGKhSVcCv8ALLB+rnQaaIO4SuQaqH53uJwn7i0nqYpr7 b2lXFomRktDpMBgaCvAA4kP9CGW/Gnl1ZM6TvcRV7cI8d5LkQeiI8cMcXc/oZ6XjFqY2 6stj+0Z+aTamVZPkbGrO74GedOFqWNgz0W+omL5VdjrDEHGG76XMjl2GbW3RkYgKciaj S/y0j2SQOlrwYcVujdTu+oWjAoh4jSAySswig+qH2spOkIlwq5QZ2ftics8kQIGMoe8P 0iOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778431724; x=1779036524; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eArBLCmYCsffvtaqVgZP4cXQn2AO6g/xQoo/oq6NlGs=; b=sgfznWlRyqxhp5otiyKrRQZF+jgy3yp5d8KabIFxm8XTjjLqA/1dRDum4dMFhPz2cM Z2pky6tIxmKOQdsoYefkJeUy+E+XcwrB9ydelOttBsBUlW/U+JOZpppBAnm6/CoxUDUR 1L3Uhk6ajt37ljmpO9pUg6UBo+yaSvSp5e/vo7aA57FT8E8H2SxbUc7hkUr2LyyNcsHU dg55VdagZpd0xQXUStZaHhyU7hQn27BAOF9V977ChX6UzAV4SzITteXv75IHjTX/kBR6 uHFP351iNaAh6mMQw32p74vUuXmrXBS8ZPsm1M6mDszbwC/hw15t40JTqPHthfiUxuui LM0g== X-Forwarded-Encrypted: i=1; AFNElJ9moSoGDE83k51CxllTpYdZH/gB423ADTU5l+yHpjhxc3mOV+qE4GIDL/UUPjnmnAUd15D/9z8=@vger.kernel.org X-Gm-Message-State: AOJu0YxFKgJwSX96lSGq1flK6gp99ZXusHGEEFWNRAtv1ixy06ays2Yi apF/LOpzdrMn41ulzwxTKC1guKqZ/YWJJsPd18wbcwgaoM9YVUXXZXeA X-Gm-Gg: Acq92OHQl7i1b3OaCaA8amZT4XVywvZ0R0kMN7ND0OP7Ii2WQvrTMgOntU85ENJIaDV 3ufE3DwLtIunrlK4IyEvu0tnfLSjFXjzixxFL/Gn/EZB6MsuOmnc2lja7tfvGVF9U/ZNG5htip/ o4UdQx2Np3Ej25iIVfm1IbgD2FOXSikCGBKTFrZNohSIWZc2V62XNRu0f0ZUQo3PVa73fkM9kNg C8h9+9NEsebMroo/bybHCb4N70ftgsb4WS9jUgQZeea6sqCVCn5N2ZzzEUjXdav/ZOAcBwIEiFM M/Qo/CjMQuM9F+nRwks/nFo75tcL8TMLNwQxCWHCKromb8Az97JIRl9C0XI1rZtraw0Yhcvrvob oRYzUnV+Q2Vjmjeg7pWZ9o8ewoFDInMmZOA8VfpnMKO0vKKXj7P/ZXCEt9L3eIs6Acg413BQzop xuj97TiJqpE5hNgAKnt9aXnjmz+3U2a5YAKl5YX62U6fCxSpQySYg5ZA== X-Received: by 2002:a17:903:9ce:b0:2ba:b5a3:1864 with SMTP id d9443c01a7336-2bab5a3210bmr186878225ad.20.1778431723638; Sun, 10 May 2026 09:48:43 -0700 (PDT) Received: from v4bel ([58.123.110.97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1eac3afsm83382135ad.71.2026.05.10.09.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 09:48:43 -0700 (PDT) Date: Mon, 11 May 2026 01:48:39 +0900 From: Hyunwoo Kim To: Jakub Kicinski Cc: dhowells@redhat.com, marc.dionne@auristor.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, qingfang.deng@linux.dev, jiayuan.chen@linux.dev, linux-afs@lists.infradead.org, netdev@vger.kernel.org, stable@vger.kernel.org, imv4bel@gmail.com Subject: Re: [PATCH net v3] rxrpc: Also unshare DATA/RESPONSE packets when paged frags are present Message-ID: References: <20260510084520.476745b5@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260510084520.476745b5@kernel.org> On Sun, May 10, 2026 at 08:45:20AM -0700, Jakub Kicinski wrote: > On Fri, 8 May 2026 17:53:09 +0900 Hyunwoo Kim wrote: > > sp->hdr.securityIndex != 0 && > > - skb_cloned(skb)) { > > + (skb_cloned(skb) || > > + skb_has_frag_list(skb) || > > + skb_has_shared_frag(skb))) { > > We seem to be getting a lot of fixes for this issue, and this one is > incorrect :| Writing to _any_ frags is incorrect. You have to copy > if skb is not linear. skb_ensure_writable() I was testing a patch based on skb_ensure_writable() but it seems v3 has just been merged to mainline... What would be the best way to proceed? Best regards, Hyunwoo Kim