From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AA424DC54B for ; Wed, 13 May 2026 17:47:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778694463; cv=none; b=iiq9TVWV/LrmXcySDUIKODkhXTCtWcHYLH1tQCMBC3mVEtP8fafKUve53Pqg7Oaf7gLjTbJ2ZuDIV4/Yz/zOO1SW2TG2nKzJXnkqplPrE/c/G3LkxBIX97jvFr3ki6NUBehs1Z79vdtxsr1NQYYfvXjAC4/EPh6E5L62QI9ILfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778694463; c=relaxed/simple; bh=/d7ugw8j3llT+i0xpw6oKwmdDsEr5lQSNXVbHHx7Bbc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JwbUMMnMpH9xorI8LyOJ7VX3woPMsjH5vCeQYG7qn9Pc3ApCXQlVYN+/0tuSlrNxZbxE9ZFbU2qnl84DfyclLEL746WxsXaBgpqNKTOUCBYfIig4UJI+/BvAkJokjZuBeiXx1uZdCRlVjf+HvZhJcDM9a1VFDKNIicvuero/THc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EuI0D8BT; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EuI0D8BT" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2b46da8c48eso4595ad.1 for ; Wed, 13 May 2026 10:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778694460; x=1779299260; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UD9g7VTOeXYFNZR2QR68/VBGy1DjrVre8yBvcooH1jI=; b=EuI0D8BToYAS/I6HIKlYInu2b17+NZ9TrapWqUu7Sl8pXtx1yKw+9p2OyGhY6jpfWc wOmF5H5vkzLjlw8LAsOIQtlethTyE4LQXH2armdgNDjI9LsIF4f3wjWmQc9rIby9QS8A +v3lkQX5fOfMrBTP0phPLV6GOCH6P/YwDRFLKXdnCbDtUnbyFPWB+wCeGRMEYdprtRiZ xJQ0DtXiLLpBZplrhJcwDZz/b1DB/5nkidmwoBXjkqc7l4gfEi5HOdsCkfOlciqNeok3 Vz5MWhVWxBPrjTkIzKrk9f2xcONFImjsGXp4sHdBmGLNhzl4Quv8r11M9vZxAyjvXsFy 9a1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778694460; x=1779299260; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UD9g7VTOeXYFNZR2QR68/VBGy1DjrVre8yBvcooH1jI=; b=qE5c86Nq/meXbfeMrsnVZ7luxJpIey6cwPb8wQGMTwanJIq5oE5SRqFnTcENyr+kke bZ7iEJeiO9BjdxblZIDuNTfOAggncgg8gk+V9RMfHw/eRGZkWpInjNDhc0cZhjlUb0FZ Xq5gWc9CXZ30Aa+egB490viVrSjy4iekV4Xlc05t+ok0cfTXw025SlF2q0X1wjt+Hxdn UI3HBC7eKb0VD+PH/va9TmP+/+e8tvfgOnLF4C6zBj087kbn19nIerVTVgYcS02f9Blx hTgUJXeVqULEbOyaYzQkjUScti1c7RHQCUPIlQo7q509cpelIq6P4cl2RA74W+kp2OX2 0wEQ== X-Forwarded-Encrypted: i=1; AFNElJ/N902mwfXJh6Zhc6p3BGRhByAUTtUAPK2JAr5S0UekQ2bVCKnJ/9Y/bRVVqO75EGiwRD+pJUY=@vger.kernel.org X-Gm-Message-State: AOJu0YyYNk0SPvBF1eyzivkJybChjnLZPLWFpulQ1sG+4QzxDognHrJ1 TmjBoMORTrF3TzzAhSQ1j7I9xTZj/poPuhUgq01q7EaDtR7woTpsAXhbRZBbrWXtLQ== X-Gm-Gg: Acq92OEOwhC6+s4YlTGj5L7zThX4FinamfxPJS5LfbuT9K6byCEwPmM6mHWRbmYiGEo LmhexDNu8NVoG8OFKAgkFJJFGGzJyk3YF7Q2p9Y+tiy6HN+Il0Auq11TncR/e1jvRXsfqYiIcMV 2ldRiJDA0gzHl+6cE2D0b7BfIsJn/eWzvyREaVUS+Q8C3ze5YPviTxJEQGtTdXL5mK6DbAJ/aRY Zy2Ira/Cgl+uHj4/G4VL3FL7jutDZnAO45VDGZ9VkE4Zmjlfo7cumqCeVbSZoLBdOcvwaBja/kJ m6CF+Mx/PHzT2LAjAhxMj799GHSE7pi6xU9A33kfpx/BT9sK10DURQcMMOUPRfCKtt29tKXGzQR YIrIIpCnqB0IhwaZhIspfrwo7FXckbrM5Mw8VfN0+/T4v4b6MuUtiLanGJ9wS9Ska+98Zu4cvvh 0Zg43yzaL6mIDBrGgJjHu68t/XK7WFLs1qxPB5noi9NCA7axYeGa+9/DYmPxGlESOpPqTc X-Received: by 2002:a17:902:db09:b0:2b4:58ad:e987 with SMTP id d9443c01a7336-2bd568f44a7mr144265ad.17.1778694460069; Wed, 13 May 2026 10:47:40 -0700 (PDT) Received: from google.com (44.234.124.34.bc.googleusercontent.com. [34.124.234.44]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19f7cc8bsm117708b3a.55.2026.05.13.10.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 10:47:39 -0700 (PDT) Date: Wed, 13 May 2026 17:47:32 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , Robin Murphy , Will Deacon , Alejandro Jimenez , Lu Baolu , Joerg Roedel , Josua Mayer , Kevin Tian , Pasha Tatashin , patches@lists.linux.dev, Samiullah Khawaja , Mostafa Saleh , stable@vger.kernel.org Subject: Re: [PATCH rc 3/5] iommu: Handle unmap error when iommu_debug is enabled Message-ID: References: <0-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> <3-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> On Tue, May 12, 2026 at 01:46:15PM -0300, Jason Gunthorpe wrote: > Sashiko noticed a latent bug where the map error flow called iommu_unmap() > which calls iommu_debug_unmap_begin()/iommu_debug_unmap_end() however > since this is an error path the map flow never actually established the > original iommu_debug_map() it will malfunction. > > Lift the unmap error handling into iommu_map_nosync() and reorder it so > the trace_map()/iommu_debug_map() records the partial mapping and then > immediately unmaps it. This avoid creating the unbalanced tracking and > provides saner tracing instead of a unmap unmatched to any map. > > Fixes: ccc21213f013 ("iommu: Add calls for IOMMU_DEBUG_PAGEALLOC") > Signed-off-by: Jason Gunthorpe Reviewed-by: Pranjal Shrivastava