From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 951334DC553 for ; Wed, 13 May 2026 17:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778694518; cv=none; b=NsPAnd1J17nudm+HFHJNSYzCaGdTD6dUJ6goMRQbXUah+pZ/SO8z7NaJDOgeY+97F1qNFzO96s28Uelmm1vnPkaAGLMaVh1LbLq66zlg9z/ynSslE6+HHxU5K7BB4xusWWXxYib4gKPdkgpLfttaX8hvlbtqtYdKBewBAH5jVt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778694518; c=relaxed/simple; bh=4XTXWoeBGoxsSNoPRmhV9IH/BD3AGgF+Q6dkrFYVktM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mtcSSiZZSsgWB+0CKG5d6zcevL4RvZOFo31mX/4E0qI84fHlxxmVPdizEGNMBAKcj417ZjFeNBZiNlsnWg8V4K1oBH5peXVk8uDwet+nVx+SOC3Sy9BGT9Fs/432OtS3YTrIcSfS3H7tkXogJkaeiLfiqSrMETh3FrTOT26cMTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YTkaB+F5; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YTkaB+F5" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2ba180a022dso4445ad.1 for ; Wed, 13 May 2026 10:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778694517; x=1779299317; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oxDXIXDykFSIYFprkEjbA73LH9dL5dkUsPQlXSJlaIw=; b=YTkaB+F5HP696WA6SIXkNRghNwCZyKOQRkNy+ieDxfGMybBNh4CSbpM8O1g98wNYet zk1896Q4nXe4xHXP1IC+OxL0bHkx57ZOa5MHGV05TvAt4rUG3Xkk0SIhW9BaQFtI/iuw W2rTOtG1uRUFXmafjVey21dh0rI2zeo3ImyrSsVnZXjfVPwQNnSOsMzlxeDxMESQVWZS OBwRiN1uJfhLocyeT6NTZrPTNFyUyzFSFLWPEF8NRyupK/WGK9AbWHpBPa9gF/h3LfK7 dX1OAUF4tzGwBxGkEs3G7LOCrPAfylZkhw+BELqoWj8uSrzCfroM4ajIdESYIOssh6iu ItkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778694517; x=1779299317; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oxDXIXDykFSIYFprkEjbA73LH9dL5dkUsPQlXSJlaIw=; b=d04lUGYhI4/awSzvfHyJw0HsgUzbGKgQ8NMOM27+CzKfqo5GTH+fYeoo+v21Qwt3Nf DIU3lqM7d9vKLInuo4k/Ac6w4GQMbunLpFl9SzImvPUhD3tQX4YSS++Peh1W128y6Wdf fqiZnMDUDrsZrS52BTduaB0B/2+RQGmntgGYsrlBdhu9bspgFaFsbuk/hJ8WZYWwb+xR s6+Npsio1/0PvxG2vT7JzOUt5AAPiIuvPMHbAoDBR54qpGxedettlpaTRn8b9tpmC4Ql U/JXlyoCgWXr+L4vOVSlH8coAt/hNJA5fQDAUDz6jbEETiIhb1hDLLO/MY7/H5eQjShc Aelw== X-Forwarded-Encrypted: i=1; AFNElJ/ISJIGXKKdL7Iti5dlYcprbNLVFUltxjxftlVRDaqw2dDddxBvyCJDmucVMQ5RWiGSiLQdpa8=@vger.kernel.org X-Gm-Message-State: AOJu0YxyVJWAMLB060CxMmWF5mSX5DQ4M/T3gU+eN/jJyQQDpCrwxmfc E0mhAbIB9uKsFI7786NR4IAI71CGmznBP7A7gV0+I7seyfToZAZQdz5NSPVAeBC1sA== X-Gm-Gg: Acq92OGeKb1/W35BMAVy36M3jnSCH6fF3d/s0vSX8yUCLSmHAwOK8odSoKeecpZppDG 7IlHBIBdNi+I2dtrTB+kV1bmwcer7JXAl4cAEIfj6lgmWvZXg/Iz1einpu4itTCoGMYrMLjC5tc 8PdWuGOp1M5QFuYTNxADFgzADP6rSan6FqOuDWU+bvmNP6RspfEfpjgLEdLuqb1Uir5eEYvGe6C TKMZNMuDW0KjLidEoL8lkHjAl8bHckWMfmAyUjzDayH9iHKxBweogIMypVcNGVVoU9hOnsbOVI5 4uw+bwhUIz3S0TaC+34M9LKm/upYgaikfDEKPcwdu9Q0psZ1Q8baemALAOoD78UUHJ9R9BLBGQI bTgz+J6Fr9oD+wWDw2CtQh6RWseo91Em5y4axEel+QAZQJXMfE9/12aI3uRa8qcTzOQ8vSfZkGK SWX1PsMJb1bwTGFgvKpYaE21HJiUy8FZYUvMAYp+TaHtYsDb23ddMSgAkAGTAWmRlHU4G5 X-Received: by 2002:a17:903:2a8d:b0:2ba:67f6:643a with SMTP id d9443c01a7336-2bd568fd5d4mr144045ad.11.1778694516241; Wed, 13 May 2026 10:48:36 -0700 (PDT) Received: from google.com (44.234.124.34.bc.googleusercontent.com. [34.124.234.44]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e35ebesm178951275ad.43.2026.05.13.10.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 10:48:35 -0700 (PDT) Date: Wed, 13 May 2026 17:48:29 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , Robin Murphy , Will Deacon , Alejandro Jimenez , Lu Baolu , Joerg Roedel , Josua Mayer , Kevin Tian , Pasha Tatashin , patches@lists.linux.dev, Samiullah Khawaja , Mostafa Saleh , stable@vger.kernel.org Subject: Re: [PATCH rc 4/5] iommupt: Check for missing PAGE_SIZE in the pgsize_bitmap Message-ID: References: <0-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> <4-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> On Tue, May 12, 2026 at 01:46:16PM -0300, Jason Gunthorpe wrote: > Sashiko pointed out that the driver could drop PAGE_SIZE from the > pgsize_bitmap. That is technically allowed but nothing does it, and > such an iommu_domain would not be used with the DMA API today. > > Still, it is against the design and it is trivial to fix up. Lift > the PT_WARN_ON to the if branch and just skip the fast path. > > Fixes: dcd6a011a8d5 ("iommupt: Add map_pages op") > Signed-off-by: Jason Gunthorpe Reviewed-by: Pranjal Shrivastava Thanks