From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76A3540629F; Fri, 15 May 2026 09:51:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778838679; cv=none; b=cIT8WWuptlr2MjvkKeCJ/FcNh0CkSt8cMJXwI0RjqDESkqxqwNLfLA5YN03sVSozeR3HBxXRdryUtVuLJodgpWL32R6HJaQ3Nz14bWTfe8vnDYXgiWGemwVvgpLGattiVO+rGHP2MdJBrsp0HzyzcG/FR8q74/u4I0yqgQ2nHyc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778838679; c=relaxed/simple; bh=qiAZjKX/MURvn7xBRGhLK35fpkW2b8CBt6CjfRs7ioo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QdWtEzm83UgP0/JhNx5597N3asswuJHOZrsLOm/kA1QwbYUW1j2xRfi6zHgRWIU3WxUDOhnTdcXawK3dRkqeGv4um2Za6GCa1zcoREUb50gY5UFWvkFOHQZ4GaYsvMULWAQMfAO8nrzWotJhZCCE8PFiQ/Rb/Ez6Xvhx269Tj1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=b1XjzH1k; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="b1XjzH1k" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778838679; x=1810374679; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qiAZjKX/MURvn7xBRGhLK35fpkW2b8CBt6CjfRs7ioo=; b=b1XjzH1kTB1VJKAyp5bqHH0fgYKb2F1AQc1lTHsZZjW1zYT/kDelFyTL KpK8YL21+8i0g5uJF9eB8bxMT3CyAry3b0SwNdqmnZ9WhiSOxBSVZ2Vqq bPIu8SMpyOJGaL4VLwssqMddpkGbOmXwb7Vs4oKXGoq54151+uKRjx/Py pYFOUkMkiQn/GXkfJHcUObeqoGl4ZHf9byT3t9myo94JlHzS42hfBGYj5 Icyhz8a///pIua1k/RxvTQRza+TLtZoUPJrs/sG6z7j2+rI7o/FkqAnWH lHYsKYBKJiz+OSSdtGdtlnFsz2nF+DgLuCjTb6M9hosjKEJEEmRgy5RNy Q==; X-CSE-ConnectionGUID: mApK2+xrRbqE6qcj/Sj1BQ== X-CSE-MsgGUID: +I6Ml1reS6Cs11uj+To1iQ== X-IronPort-AV: E=McAfee;i="6800,10657,11786"; a="79834912" X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="79834912" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 02:51:18 -0700 X-CSE-ConnectionGUID: Ip8wcBmVQbeQ5pTed9DXDg== X-CSE-MsgGUID: sGNThLzOTXKyDJkhLHLyQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="240459884" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.33]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 02:51:15 -0700 Date: Fri, 15 May 2026 12:51:13 +0300 From: Andy Shevchenko To: Joshua Crofts Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Gregor Boirie , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Sashiko , stable@vger.kernel.org Subject: Re: [PATCH] iio: magnetometer: ak8975: fix potential kernel stack memory leak Message-ID: References: <20260514-magnetometer-kernel-mem-leak-v1-1-35b48d699faf@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Fri, May 15, 2026 at 11:00:17AM +0200, Joshua Crofts wrote: > On Thu, 14 May 2026 at 13:38, Joshua Crofts via B4 Relay > wrote: ... > > - if (ret < 0) > > + if (ret != sizeof(fval)) { > > Hmm, Sashiko pointed out that I am comparing a signed integer with > an unsigned integer, which would result in type promotion and subsequent > mangling of any potential negative values... will fix in v2. > > https://sashiko.dev/#/patchset/20260514-magnetometer-kernel-mem-leak-v1-1-35b48d699faf%40gmail.com See my response. That how it should be in your v2. -- With Best Regards, Andy Shevchenko