From: Ben Hutchings <benh@debian.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>
Cc: stable <stable@vger.kernel.org>,
Salah Triki <salah.triki@gmail.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>
Subject: [PATCH 5.10] Revert "s390/cio: Fix device lifecycle handling in css_alloc_subchannel()"
Date: Tue, 26 May 2026 11:56:02 +0200 [thread overview]
Message-ID: <ahVuMv5SLjHVUbkt@decadent.org.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
This reverts commit 2b2ad7ad4a28ffdb9f94e6d979b88a5b12b71681, which
was commit f65c75b0b9b5a390bc3beadcde0a6fbc3ad118f7 upstream. The
order of initialisation and error paths in this function are
substantially different in 5.10 and this backport did not take that
into account.
Signed-off-by: Ben Hutchings <benh@debian.org>
---
drivers/s390/cio/css.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/cio/css.c b/drivers/s390/cio/css.c
index e5e20ea850aa..cf2c3c4c590f 100644
--- a/drivers/s390/cio/css.c
+++ b/drivers/s390/cio/css.c
@@ -241,7 +241,7 @@ struct subchannel *css_alloc_subchannel(struct subchannel_id schid,
return sch;
err:
- put_device(&sch->dev);
+ kfree(sch);
return ERR_PTR(ret);
}
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2026-05-26 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 9:56 Ben Hutchings [this message]
2026-05-26 10:21 ` [PATCH 5.10] Revert "s390/cio: Fix device lifecycle handling in css_alloc_subchannel()" Vineeth Vijayan
2026-05-26 13:38 ` Sasha Levin
2026-05-26 15:25 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahVuMv5SLjHVUbkt@decadent.org.uk \
--to=benh@debian.org \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=salah.triki@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox