Re: + errh-use-__always_inline-on-all-error-pointer-helpers.patch added to mm-nonmm-unstable branch

[Petr Mladek <pmladek@suse.com>]

On Tue 2026-06-02 09:46:33, Tamir Duberstein wrote:
> On Tue, Jun 2, 2026 at 8:41 AM Petr Mladek <pmladek@suse.com> wrote:
> >
> > Adding Tamir into Cc.
> >
> > On Tue 2026-06-02 11:36:30, Andy Shevchenko wrote:
> > > On Tue, May 26, 2026 at 11:40:59AM -0700, Andrew Morton wrote:
> > >
> > > > The patch titled
> > > >      Subject: err.h: use __always_inline on all error pointer helpers
> > > > has been added to the -mm mm-nonmm-unstable branch.  Its filename is
> > > >      errh-use-__always_inline-on-all-error-pointer-helpers.patch
> > > >
> > > > This patch will shortly appear at
> > > >      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/errh-use-__always_inline-on-all-error-pointer-helpers.patch
> > >
> > > Petr, shouldn't this also fix the problem with old (buggy) GCC for xtensa
> > > (IIRC) that we encountered in some tests a couple of months ago?
> >
> > It might here there as well. Unfortunately, I could not test it easily
> > because it required some old GCC.
> >
> > I wonder if Tamir could try to revert the commit 8901ac9d2c7eb8ed
> > ("printf: Compile the kunit test with DISABLE_BRANCH_PROFILING")
> > and try this patch instead.
> 
> Yes, confirmed.
> 
> I rebuilt xtensa-linux GCC 8.5.0 and tested printf_kunit.c with the original
> randconfig and branch profiling enabled, without DISABLE_BRANCH_PROFILING.
> 
> Without Arnd's patch, the original failure reproduces:
> 
> printf_kunit.c: In function 'errptr.part.2': error: call to
> '__compiletime_assert_313' declared with attribute error: BUILD_BUG_ON failed:
> IS_ERR(PTR)
> 
> With "err.h: use __always_inline on all error pointer helpers" applied, the same
> compile succeeds.
> 
> So Arnd's patch fixes this case and commit 8901ac9d2c7e ("printf: Compile the
> kunit test with DISABLE_BRANCH_PROFILING") can be reverted once it lands.

Great. Thank you both for pointing it out and testing it!

It seems that it is not in the Linus' tree yet. I guess
that it will appear in the 7.2 merge window, ...
I set up reminder to myself.

Best Regards,
Petr