From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63B883CC330 for ; Fri, 26 Jun 2026 12:03:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782475422; cv=none; b=lUCA5nSzIW8YFUA22RrEuqPFuXXag9MetSdzgs7FZwGEX//u93Ihnpiwvt+JvTqTh23LVRyxJvkvv3QHN7OLTQ50C89R5rI5qg+SIjRivPBumFqTUYOVPnph78Sj11NjZNlyl82BQqCPQHjeMYU7iYQt+4F9yREl8cmHmgXPk+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782475422; c=relaxed/simple; bh=CWXb+4thCgNlHUqML3azUtSDuVlrACHoggD+fOCUJeA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LaSHkVxxX3zItBWyaNTLnYMhnwnBgoqYiqGerJc3J1d7e7yhkP5D5/J3KT9v+GsEqFf/vOzWeiaf0nh0zyi4le1TiUy8n4h2IVHPz8zo4YV+L4KikU/4fX5cGcRx8NHNPb7uvLvPbAoxhaSX8zKm3v1WYYkfkfKRYIVMV5oOqNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lrjUtRkm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lrjUtRkm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2C7A1F000E9; Fri, 26 Jun 2026 12:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782475421; bh=M+O8tsJQndsfmCOxVs6WQWK/G9XK0qBCLMq98dP4CqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=lrjUtRkmeDylsGTxNEHtOePh1aCK2XrzEsz80+cPPLy//PrX/DOiRdcA9ztD8Md/w NfAcljoHZ3BdbxP/RVqVi7l6WlnDXuA9nZbKjUogzfnNjGBib0WzuEL+0A410/6UVZ 7I8GeVMpXxsd8ax4WXlp3mHW4kT8l1REahR0Q/EU2oQaX9MNYdAt/J3DKZWYPRMZ1w cZ1QBH5Z4Kdcs4TBL9IATQLTEwfoCFrByobdGBp1r6MwR7HU0v0qi0r3G2wF+ygXV3 yvYSTl77eWn6mjhm3HY5KO8EtxnhGEQKt31LOS8VXaBi7kMwhpHoF21ht+TvHzo39B zFLEFRJu9KeIg== Date: Fri, 26 Jun 2026 13:03:33 +0100 From: Lorenzo Stoakes To: "David Hildenbrand (Arm)" Cc: Ethan Nelson-Moore , Vlastimil Babka , Jann Horn , Pedro Falcato , Andrew Morton , "Liam R. Howlett" , Alice Ryhl , linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: fix CONFIG_STACK_GROWSUP typo in tools/testing/vma/include/dup.h Message-ID: References: <20260611012258.432043-1-enelsonmoore@gmail.com> <8fc34141-b8a7-43fd-8c84-f843bd34fb9f@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8fc34141-b8a7-43fd-8c84-f843bd34fb9f@kernel.org> On Wed, Jun 17, 2026 at 01:09:26PM +0200, David Hildenbrand (Arm) wrote: > On 6/11/26 03:22, Ethan Nelson-Moore wrote: > > Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") significantly > > refactored the header file include/linux/mm.h. In that step, it introduced > > a typo in an ifdef, referring to a non-existing config option > > STACK_GROWS_UP, whereas the actual config option is called STACK_GROWSUP. > > > > Commit 40a4af52e047 ("mm: fix CONFIG_STACK_GROWSUP typo in mm.h") fixed > > this typo in the mm.h header file, but did not update the copy of the > > code in tools/testing/vma/include/dup.h. Update this copy as well. > > > > Commit message adapted from the above-referenced fix to mm.h. > > > > Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit") > > Cc: stable@vger.kernel.org # 7.0+ > > This is in tools/testing/vma. Why does this require a stable tag? > > What is the resulting problem (in the test!) that we even care about the Fixes: tag? Yeah I doubt very much that stable users are running VMA userland tests on parisc :)) > > If there is no user visible (test!) problem, then this is merely a cleanup, not > a bugfix. Yeah I think moreso this. > > Change itself LGTM. > > > Signed-off-by: Ethan Nelson-Moore > > --- > > tools/testing/vma/include/dup.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/vma/include/dup.h b/tools/testing/vma/include/dup.h > > index 9e0dfd3a85b0..adbc3179085d 100644 > > --- a/tools/testing/vma/include/dup.h > > +++ b/tools/testing/vma/include/dup.h > > @@ -243,7 +243,7 @@ enum { > > #define VM_NOHUGEPAGE INIT_VM_FLAG(NOHUGEPAGE) > > #define VM_MERGEABLE INIT_VM_FLAG(MERGEABLE) > > #define VM_STACK INIT_VM_FLAG(STACK) > > -#ifdef CONFIG_STACK_GROWS_UP > > +#ifdef CONFIG_STACK_GROWSUP > > #define VM_STACK_EARLY INIT_VM_FLAG(STACK_EARLY) > > #else > > #define VM_STACK_EARLY VM_NONE > > > -- > Cheers, > > David Thanks, Lorenzo