From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 660613F4134 for ; Fri, 26 Jun 2026 12:06:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782475592; cv=none; b=I+nnNAtqCR62ov34XV/qzS8CHEb3fvukFW/AorfS6mdRbljHN3i9/fD0ZWVWqbRqaohcMEFDTzteyF7FUvIACxP9hmQOYM3cTolweizCpuCwAyubR6PaRTmzB7lWgSyCMSEa5PTBqTNqhiPbVRXyq51bUMKIWAdmyBdV+FlythA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782475592; c=relaxed/simple; bh=oA3l/vucteIpjI/8m54kvsuw6yyKtM+W3WDN4uvfG8s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eqSVYOrFozfD4j1LJvrZgA/o4otCWLPCwCwBpjSHPyPsK1+GsThUlBuXB9OePdqnbvSzk+eaS5SU4e1gYUBvAVY7M0V7Eyqdjqz0XLXl1Ef03lD5SbVcy9Ny/gtMP3CrJBisjshOrWZkFZ62vh7pcipC7Ny+nbz4MWndLSB0wRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HuLiCafF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HuLiCafF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CE9F1F000E9; Fri, 26 Jun 2026 12:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782475591; bh=CR/q+u4UxqSX/SXdvCBsFabJIJzu5N3mtpvnRKl9G+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=HuLiCafF27i+a1Hwbe58UcUWXi+RtmTlsiS1578ZPbFvyClVUMajIx4xvQq1Nn9MW 6U9H0QCEquJHo5VesQ4uw/caR8kMCLxe/nFB59OF7KtpZiRUrh0cuf6AOVwt/zP1bJ sXe63MHAbjGiDG2Nef7mAnwdboy4eJuhMEe5QZJusYZ+4XkVGtrDtnKkodet8xtO31 zUUEh1HFS/oV6/plnRvAFtq8v/w075BqMhU3Sc+KEzY+vTFxFd3uZgAHPVemYOqkrZ TEm+sXgtZqQN/Jef6Wk7mfhIzzZhNGqRnfFkvJdoHDBShsbePempzC73XGjppHzGVA F7pI/mUK+NtQw== Date: Fri, 26 Jun 2026 13:06:23 +0100 From: Lorenzo Stoakes To: Ethan Nelson-Moore Cc: Vlastimil Babka , Jann Horn , Pedro Falcato , Andrew Morton , "Liam R. Howlett" , Alice Ryhl , linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: fix CONFIG_STACK_GROWSUP typo in tools/testing/vma/include/dup.h Message-ID: References: <20260611012258.432043-1-enelsonmoore@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260611012258.432043-1-enelsonmoore@gmail.com> On Wed, Jun 10, 2026 at 06:22:44PM -0700, Ethan Nelson-Moore wrote: > Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") significantly > refactored the header file include/linux/mm.h. In that step, it introduced > a typo in an ifdef, referring to a non-existing config option > STACK_GROWS_UP, whereas the actual config option is called STACK_GROWSUP. > > Commit 40a4af52e047 ("mm: fix CONFIG_STACK_GROWSUP typo in mm.h") fixed > this typo in the mm.h header file, but did not update the copy of the > code in tools/testing/vma/include/dup.h. Update this copy as well. > > Commit message adapted from the above-referenced fix to mm.h. > > Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit") > Cc: stable@vger.kernel.org # 7.0+ Actually since we don't set the config options like the kernel does in userland tests, this can't actually be something that you can get to happen :P So drop both Fixes, and the Cc: stable please as per David (Andrew - can you make that change? Thanks!) > Signed-off-by: Ethan Nelson-Moore Thanks for fixing this however! I typo'd this in the actual code but didn't update the VMA userland test code. Appreciate the cleanup! So, with the fixes, Cc: stable tags dropped: Reviewed-by: Lorenzo Stoakes > --- > tools/testing/vma/include/dup.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/vma/include/dup.h b/tools/testing/vma/include/dup.h > index 9e0dfd3a85b0..adbc3179085d 100644 > --- a/tools/testing/vma/include/dup.h > +++ b/tools/testing/vma/include/dup.h > @@ -243,7 +243,7 @@ enum { > #define VM_NOHUGEPAGE INIT_VM_FLAG(NOHUGEPAGE) > #define VM_MERGEABLE INIT_VM_FLAG(MERGEABLE) > #define VM_STACK INIT_VM_FLAG(STACK) > -#ifdef CONFIG_STACK_GROWS_UP > +#ifdef CONFIG_STACK_GROWSUP > #define VM_STACK_EARLY INIT_VM_FLAG(STACK_EARLY) > #else > #define VM_STACK_EARLY VM_NONE > -- > 2.43.0 > Cheers, Lorenzo