From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mx1.scotdoyle.com ([23.226.141.211]:55306 "EHLO
	mx1.scotdoyle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751153AbcBOVST (ORCPT
	<rfc822;stable@vger.kernel.org>); Mon, 15 Feb 2016 16:18:19 -0500
Date: Mon, 15 Feb 2016 15:12:43 -0600 (CST)
From: Scot Doyle <lkml14@scotdoyle.com>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
cc: linux-fbdev@vger.kernel.org,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Pavel Machek <pavel@ucw.cz>,
	Thierry Reding <treding@nvidia.com>, stable@vger.kernel.org
Subject: Re: [PATCH] fbcon: set a default value to blink interval
In-Reply-To: <1455561693-28615-1-git-send-email-jean-philippe.brucker@arm.com>
Message-ID: <alpine.DEB.2.10.1602151500060.14844@laptop>
References: <1455561693-28615-1-git-send-email-jean-philippe.brucker@arm.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Mon, 15 Feb 2016, Jean-Philippe Brucker wrote:
> Since commit 27a4c827c34ac4256a190cc9d24607f953c1c459
> 	fbcon: use the cursor blink interval provided by vt
> 
> two attempts have been made at fixing a possible hang caused by
> cursor_timer_handler. That function registers a timer to be triggered at
> "jiffies + fbcon_ops.cur_blink_jiffies".
...
> Instead of patching all possible paths that lead to this case one at a
> time, fix the issue at the source and initialise cur_blink_jiffies to
> 200ms when allocating fbcon_ops. This was its default value before
> aforesaid commit. fbcon_cursor or fbcon_init will refine this value
> downstream.
> 
> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> Cc: <stable@vger.kernel.org> # v4.2

I agree with the approach and the patch works on my x86_64.

Tested-by: Scot Doyle <lkml14@scotdoyle.com>