From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Date: Thu, 25 Jan 2018 15:03:13 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Jiri Slaby <jslaby@suse.cz>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Li Jinyue <lijinyue@huawei.com>, peterz@infradead.org,
        dvhart@infradead.org
Subject: Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input
 validation
In-Reply-To: <20567b49-e0a3-e9e0-d520-74bbfc20d414@suse.cz>
Message-ID: <alpine.DEB.2.20.1801251502310.2020@nanos>
References: <20180122083954.683903493@linuxfoundation.org> <20180122083956.427607580@linuxfoundation.org> <20567b49-e0a3-e9e0-d520-74bbfc20d414@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, 25 Jan 2018, Jiri Slaby wrote:
> On 01/22/2018, 09:44 AM, Greg Kroah-Hartman wrote:
> > +	if (nr_wake < 0 || nr_requeue < 0)
> > +		return -EINVAL;
> 
> This breaks strace's test suite on 4.14.15 (and is present in upstream
> obviously too):
>     futex(0x7ff568b44ffc, 0x3, 0xfacefeed, 0xbadda7a0ca7b100d,
> 0x7ff568b44ffc, 0x9caffee1) = -1: Invalid argument

And why the hell is strace expecting this to be valid?

Thanks,

	tglx