From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21B8437BE71 for ; Mon, 3 Aug 2026 23:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785800023; cv=none; b=t1BeIIWBzrG5sK47UJmBHaIiCp1+2eQkt2h/b9SSgSz0q+aCjLewhjX6AVogE2tuNdddCnLuKfl+YwZP4QNKyTnC7iwnZ06hQN1SyoauYS+mufr6zlKaMcnZxM6ZMceD9RakBLxNr1VdBxDLPARfZXu74mhXs2jlB41UGF3/76M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785800023; c=relaxed/simple; bh=MgBl1tjaTrOko8MnuN3rOVFNmFaTGLEvWTS5I1o0Blg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kGS+iHiCfpddXXkXHD1gIawdvm/jvjchsT6BFSkm63kqydj5nxy2ROJ6it98LBDNWt+Y/Srrix/FgpBxqDhYKdh/KqbnuJrbdRslwgdPaT8oXKnOD1wjZAgtaQ3ESBd0M0BSrHAt+DoEgDR1ks3/Y+Da3/tVb+PNPbQqoTxDR3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CUfAjpW5; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CUfAjpW5" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-cbb973e6749so4422564a12.1 for ; Mon, 03 Aug 2026 16:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785800021; x=1786404821; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QeqgW/4lTIg3SEDE03Q3XP4TRyhw16cUEWUdFHbkHtU=; b=CUfAjpW5UsBgcHH5Jm8/6yCif3diFamGY9jWV5MxlMlWa+R0hg3c88k96LSNQuZyev hEiS3ujDxnV+sOXAAzY39b4JosEUxh7SaP3ss4MlyBp+NGJfe2XYC2XTrqDspJrFv7gC QnXR49uVztlS3cI2YIJD7UcNYCNx35aLqhWFMuoD+uGuDkrJFelPTCSDdWdkJPs/dbzR PXJQAR6zpwAL1Mww24gGUG4ajVYlxtk7igLMBSGvYUefXeXRyOu7J+/rz8KQYSSyTjCN ZL8FQY5UQwPCecQzJLpPEsyv44Pm9rPmWdCBAyQ1WOgM3JLQpM7g9n6sTEfA+ux/2CcL 8B3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785800021; x=1786404821; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QeqgW/4lTIg3SEDE03Q3XP4TRyhw16cUEWUdFHbkHtU=; b=Rlua/lFC1JxmsUns6hBK7u/wr0BvHhdYB4VNysapfGVH+QtZCPq93cKc9b8mHAjHHD gnT8Aijh1rMxemmuOzTcCwknZ1SMAsD6LuJafdfmdVblSzv8fbtf6BBWA0Tp/TefYcFA BunY3hh3Ng/KetsKDD5gOdrlYAV1xapwRwAD62gfqssk2M69qisei8Rqi9RBg175ufud ElHq9STTMoDY8oii+tzQuLNWCkyA21VgcMDS3GRsJa3ylcC1Uy89JZU2LMVv8OBJf08q CdXp54sFb9mfvhKHqu/OLp53cc+o2R1X7QL+EiEKjyM1qv84ucaVoCk97GGi0d8FPsId QuPw== X-Forwarded-Encrypted: i=1; AHgh+RrmuNK3xqI28SFQZ8iuS0ULO6HAeC2yjkgFQkxyWDfCVRRdfGH97Z+mThK7+r3QXYmJHaBAsrw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0mfo1zSz8ijTla5mZ3wpU4fnYM1UTSCq4T+bVW70e5IVHdo+f Ghlcp6RZejOFzHFDDdhO10zyJ4FUsIYCb5qY0WYiUA0kQ+5OORJUepgzXs5+nQ== X-Gm-Gg: AR+sD13dBMXTioLWPnnkvCglrCinQNX18l5GkF8NRhZdUE3X3t4fr/NDTdtO0GmSd18 s7fatrocFsXtgkz0Od7qLgRajFr/7KnhWcz1eEQFEPWHQUfVPHtZ7hfefw87vaLRVBPp5Fcm96i Pbo1UVXtpfHx7ySVe5XTAsxnOyaynQRCO2hYoTeWUkQdsyoK8zLwGRBuKQ9IOi8sFVaQJ6kO58R /JRHvheWd+uo4y5VCCKEmMlNnLj7XevOKw4ZDITB6hB5I+njSzSaoNYoOoW+1XaQxpVTMxldvJe b4539iLHFlQtFZxK+qbmcSIdkPXTRBlcvVPEzM6SaLKDb5k55ThtfkN2Tb64HZDkNezGZOgSoEk MjYkBXrmLI9DQeFKO4jq9c9o5x3xcMEbqkZNv48BH6dHp6z8BMoIBtLkJSn/zLc05zj9yi6jeoP Ws2ey+SoxxafRIiESQdne1HMYjESHG3eSjKx/2IS1q1t60dAKJRJH/2l9WKDJzb/Blry5lcVnib 0lcEhltgKdp/IitM8B7s+6F3LFoxmA5q/L/+AOL X-Received: by 2002:a05:6a21:a89:b0:3b3:223f:d3fc with SMTP id adf61e73a8af0-3c92a864c77mr11650058637.45.1785800021346; Mon, 03 Aug 2026 16:33:41 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:d109:cdba:8a20:74ad]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e06f88fsm41168805eec.20.2026.08.03.16.33.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 16:33:40 -0700 (PDT) Date: Mon, 3 Aug 2026 16:33:37 -0700 From: Dmitry Torokhov To: Shengzhuo Wei Cc: "Derek J. Clark" , Jiri Kosina , Benjamin Tissoires , Zhouwang Huang , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] HID: hid-oxp: fix UAF on pending work in remove() Message-ID: References: <20260804-oxp-fix-v1-1-51a4fe787167@cherr.cc> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260804-oxp-fix-v1-1-51a4fe787167@cherr.cc> Hi Shengzhuo, On Tue, Aug 04, 2026 at 07:15:32AM +0800, Shengzhuo Wei wrote: > oxp_cfg_probe() arms drvdata.oxp_mcu_init to run 50 ms after probe, and > oxp_mcu_init_fn() dereferences drvdata.hdev to issue MCU output reports > (oxp_set_buttons()/oxp_gen_2_property_out() -> hid_hw_output_report(), > each followed by msleep(200)). oxp_hid_remove() cancels it with the > non-synchronising cancel_delayed_work(), so a worker already running is > not waited for; removing the device while the worker is asleep then frees > the hid_device underneath it, leaving drvdata.hdev stale -- a > use-after-free when the worker wakes. > > The oxp_rgb_queue and oxp_btn_queue workers, wired up the same way and > also cancelled with cancel_delayed_work() in oxp_hid_remove(), have the > same problem. > > Drain all three works with cancel_delayed_work_sync() in oxp_hid_remove() > so they have exited before the hid_device is freed. > > Fixes: 84910c459d65 ("HID: hid-oxp: Add OneXPlayer configuration driver") > Fixes: e4c850a6e750 ("HID: hid-oxp: Add Button Mapping Interface") > Fixes: 2f424f28fb39 ("HID: hid-oxp: Add Second Generation Gamepad Mode Switch") > Cc: stable@vger.kernel.org > Signed-off-by: Shengzhuo Wei > --- > Same delayed-work use-after-free class as the 7.2-rc6 sweep > (hid-lenovo-go, hid-lenovo-go-s, hid-lg-g15, hid-appleir, hid-letsketch); > hid-oxp was missed. The fix mirrors the cancel_delayed_work_sync() > approach already used by hid-lenovo-go / hid-lenovo-go-s. > --- > drivers/hid/hid-oxp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hid/hid-oxp.c b/drivers/hid/hid-oxp.c > index 20a54f337220dc2aee3483a14d542b66c487bd60..d8fb6a69d40d43f2595179df1067d42b4b3e166a 100644 > --- a/drivers/hid/hid-oxp.c > +++ b/drivers/hid/hid-oxp.c > @@ -1552,9 +1552,9 @@ static int oxp_hid_probe(struct hid_device *hdev, > > static void oxp_hid_remove(struct hid_device *hdev) > { > - cancel_delayed_work(&drvdata.oxp_rgb_queue); > - cancel_delayed_work(&drvdata.oxp_btn_queue); > - cancel_delayed_work(&drvdata.oxp_mcu_init); > + cancel_delayed_work_sync(&drvdata.oxp_rgb_queue); > + cancel_delayed_work_sync(&drvdata.oxp_btn_queue); > + cancel_delayed_work_sync(&drvdata.oxp_mcu_init); What stops these jobs from re-arming? Should it use disable_delayed_work_sync() instead? Thanks. -- Dmitry