From: Sasha Levin <sashal@kernel.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: stable@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH 6.18.y] can: isotp: fix timer drain order, wakeup handling and tx_gen ordering
Date: Thu, 6 Aug 2026 13:40:25 -0400 [thread overview]
Message-ID: <anTHCfIquCTzW52G@laps> (raw)
In-Reply-To: <6596e764-a9d8-4557-99e5-585bd680c3ef@hartkopp.net>
On Thu, Aug 06, 2026 at 02:09:36PM +0200, Oliver Hartkopp wrote:
>
>
>On 06.08.26 13:36, Sasha Levin wrote:
>>The skb->hash echo tag doesn't work here. isotp_set_skb_uid() is only
>>called from the TX paths, never from isotp_send_fc(), so FC loopback
>>echoes arrive with skb->hash == 0 and alias the so->cfecho == 0 "nothing
>>pending" sentinel. Upstream is fine because d4fb6514ff8e stamps the UID
>>in can_receive(), but that commit isn't on 6.18.
>>
>
>Ouch! Thanks for catching this!!
>
>I just focused on isotp.c - my bad.
>
>What would be your suggestion to solve this issue?
>
>1. create a 2-patch series which applies d4fb6514ff8e first?
>2. turn it back to the original if (so->cfecho != *(u32 *)cf->data) code?
>
>The latter was tagged by sashiko-bot to be not safe enough.
I think that just a 2 patch series would make the most sense. Thanks!
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-08-06 17:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 12:03 FAILED: patch "[PATCH] can: isotp: fix timer drain order, wakeup handling and tx_gen" failed to apply to 6.18-stable tree gregkh
2026-08-05 12:54 ` [PATCH 6.18.y] can: isotp: fix timer drain order, wakeup handling and tx_gen ordering Oliver Hartkopp
2026-08-06 11:36 ` Sasha Levin
2026-08-06 12:09 ` Oliver Hartkopp
2026-08-06 17:40 ` Sasha Levin [this message]
2026-08-07 8:05 ` Oliver Hartkopp
2026-08-21 7:00 ` Oliver Hartkopp
2026-08-25 11:49 ` Sasha Levin
2026-08-25 12:27 ` [PATCH 5.10.y 1/2] can: use skb hash instead of private variable in headroom Oliver Hartkopp
2026-08-25 12:27 ` [PATCH 5.10.y 2/2] can: isotp: fix timer drain order, wakeup handling and tx_gen ordering Oliver Hartkopp
2026-08-25 12:27 ` [PATCH 5.15.y 1/2] can: use skb hash instead of private variable in headroom Oliver Hartkopp
2026-08-25 12:27 ` [PATCH 5.15.y 2/2] can: isotp: fix timer drain order, wakeup handling and tx_gen ordering Oliver Hartkopp
2026-08-25 12:27 ` [PATCH 6.1.y 1/2] can: use skb hash instead of private variable in headroom Oliver Hartkopp
2026-08-25 12:27 ` [PATCH 6.1.y 2/2] can: isotp: fix timer drain order, wakeup handling and tx_gen ordering Oliver Hartkopp
2026-08-07 7:52 ` [PATCH 6.18.y v2 1/2] can: use skb hash instead of private variable in headroom Oliver Hartkopp
2026-08-07 7:52 ` [PATCH 6.18.y v2 2/2] can: isotp: fix timer drain order, wakeup handling and tx_gen ordering Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anTHCfIquCTzW52G@laps \
--to=sashal@kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox