From: "Jose Fernandez (Anthropic)" <jose.fernandez@linux.dev>
To: Peter Zijlstra <peterz@infradead.org>
Cc: John Stultz <jstultz@google.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
Sasha Levin <sashal@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Janne Huttunen <janne.huttunen@nokia.com>,
Zicheng Qu <quzicheng@huawei.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Shubhang Kaushik <shubhang@os.amperecomputing.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Xuewen Yan <xuewen.yan@unisoc.com>,
William Montaz <willymontaz@gmail.com>
Subject: Re: [PATCH 6.18] sched/fair: Revert 6d71a9c61604 ("sched/fair: Fix EEVDF entity placement bug causing scheduling lag")
Date: Mon, 10 Aug 2026 23:31:34 +0000 [thread overview]
Message-ID: <anpfJp_tuKDuePJM@linux.dev> (raw)
In-Reply-To: <20260810073830.GC1642880@noisy.programming.kicks-ass.net>
On Mon, Aug 10, 2026 at 09:38:30AM +0200, Peter Zijlstra wrote:
> Yeah, this should be fine without 4823725d9d1d.
One heads up, our review tooling caught this after I sent the
Tested-by. The revert was written after commit 80390ead2080
("sched/fair: Separate se->vlag from se->vprot") took vlag and vprot
out of their union, and 6.18 still has the union. Without that split
first, the rel_vprot path in the new reweight_entity() scales vlag
twice and curr's vruntime comes out wrong.
next prev parent reply other threads:[~2026-08-10 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260324100126.3502-1-willymontaz@gmail.com>
2026-04-15 21:10 ` [PATCH 6.18] sched/fair: Revert 6d71a9c61604 ("sched/fair: Fix EEVDF entity placement bug causing scheduling lag") John Stultz
2026-08-10 1:44 ` Jose Fernandez
2026-08-10 7:38 ` Peter Zijlstra
2026-08-10 23:31 ` Jose Fernandez (Anthropic) [this message]
2026-08-10 23:38 ` John Stultz
2026-08-10 23:57 ` Sasha Levin
2026-08-11 0:11 ` John Stultz
2026-08-11 18:55 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anpfJp_tuKDuePJM@linux.dev \
--to=jose.fernandez@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=janne.huttunen@nokia.com \
--cc=jstultz@google.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=quzicheng@huawei.com \
--cc=sashal@kernel.org \
--cc=shubhang@os.amperecomputing.com \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=willymontaz@gmail.com \
--cc=xuewen.yan@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox