From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E78951F938 for ; Wed, 26 Aug 2026 18:11:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787767886; cv=none; b=XrDkIj7I8cJ0hls6aKjqo5wNxWC5F1N7x9U8waluTod1aIhztKjdh92bDdz6Qyjatr9nu2S8hTDUXnPIuhqPf4Z2KM31kA3HnOqHHkmcBdoz95YN0NTl0kYQtgFBLPEHZaAjg9liJvmH9YiWrX4vi3e3Am7Rox+duTYBs3zp3kM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787767886; c=relaxed/simple; bh=hTwLH6239DZe5yRPzb2V1G2GAB6G4ulnXpvuKPufiFg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jKiClNj4lNaY19EcJS7gzJF3ziKDmixrjU9DWtaUjSCsvPbsrh3BywmvjNhatGsxvakkUeI5tuK+nDop/xSUc+qnk95n4N23evVeV1v8C6sqcZuuZmS+dzN1QLYmPubFt41axMr18VU+yR2T3wBm/fxcVhBsKSCWV+ChAujbwpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RuAY91T2; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RuAY91T2" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-cc1cc1b42b5so751969a12.2 for ; Wed, 26 Aug 2026 11:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787767874; x=1788372674; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=cD3ENK5Zz4cqB8cAmknAH7JmVcmInLZ6RJTKj7LW1gE=; b=RuAY91T2VT7db4CGw4AR51PDL+85j6oXkjMPaLH2/s1nxhrYPR8B/EXMR32BTrWAiv 15TIkfG3CpxQ0TL425qNPYlA1xVp/lY93yC/KTzu1adajr0zloMRzEeiJcs0V63QmZxb 53Y2F4nhZWzC5N/YRjPDS1X5IfdsA5FFJVNOJsCd8dyOtYYz4jYoEzLnpZP9rBSZ0LcF RDvr4gqCw93QoJZHC82D8ksZsFBbLWm8noxekevS0Bez3Y1H34mfK/KSQ8QauLLxQ3NP 4hHpBWmsXDTbvb5jn7P6zLmMtL4lNbvBpixJcR1oY+1rLNaNRGEzMhHfcUOlZLBZTSvJ I5Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787767874; x=1788372674; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cD3ENK5Zz4cqB8cAmknAH7JmVcmInLZ6RJTKj7LW1gE=; b=YOBEgChEnvYBwRK4dOVJW5hfQovvome7hJnVRUQ4p7dTYQOyUM2pjZKHQm7syUICaX BO24n9Yw8umkyT0/yItry+gmJ7BxTy9NTDKZge4BP9IqCPYbL5J/dJlbddi8VhKjYBTi 7kChcupvhvqN+2xQuBDL1IjSBWXWTIcwD3vgcbTMO43n7lRVdQrt0TuKDGl+mQipgFTX 4WaY7E5rPD6PV/5PxDpDFcC39zlDfurXBTiYE1IYzM//28+aaeb0d01iUuYNFb3M2J1q 86vAbFpBSkZ/E8Badsfc2UboZmFxKZG3uvCYn4OxyRinrCuGM1FaiGridd6MXCGIClxB xWag== X-Forwarded-Encrypted: i=1; AHgh+RpoFFeEbxsoDIVbkbyEh9nhFd1JpCsKE2YxrQhKwO0N8cChu0tVC3Zu2PSy5ZzLNhHsZbOaJJE=@vger.kernel.org X-Gm-Message-State: AFuF++lWHgr5uIatyi3EbaLMlV25SnJxm4fuA3aqROalfd4FTOPVVm6D DyrH3oMnTa7a9J1OgfWXVs2jjBznscAREPteN1h9gMb3f7VpFw7GVHEM X-Gm-Gg: AR+sD12jz5e+O4wz3VQ83ZrJGEjmIAfkxLUKD5L3gHt6l1lrwMhHA8YwDnYHtmL6zTS CrZvdzV52ug99VkN1XJmY5Dr+PM/TEeDc+E+cnHp4E/pKsyQiW0HKnaQJN2mFBo7H3s0N0enyIS qbrvKP4O71oEnprPP6pWmsBS27mRSzHLLWosWGrnaBvI1j5y27G/7Hj11SmL6At/GanWRJVrNCn PRdB6l2TOQbfOw4bgb+qSqABWuqNKNrsVAt2mjo4J26wcxt/yKTKf6I4fnzRABaE35xFEoNc79W 1EDsy8k3FpxEUhtRzmAGaTaPM2VrldFfS16bpPluFwhmU5aX2GiXVjUDg18MeiTfaNy1xhEhcG0 +HZqnthwAWxU8jDirrC2qdKTQWyBTTkk9V0+hbq8+ifiMNWPqQwBqc1xJt806Y5Esfpt0g7KlXG 2VXmuSPIFFo0eQEyoZARF1s9e5I7a/xmTvYpJhusE/HPPCQxPThPNwwkmsPIOecDqQgWLW0UfMH Wovl8CxG8UTXfi+dZpZWASKbDN5tN1K X-Received: by 2002:a05:6a20:6a09:b0:3cb:8810:631d with SMTP id adf61e73a8af0-3cf7596814emr15778521637.1.1787767873764; Wed, 26 Aug 2026 11:11:13 -0700 (PDT) Received: from localhost ([2409:40c4:3158:4e86:4090:3289:19be:7446]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-32854db74eesm957162eec.18.2026.08.26.11.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 11:11:13 -0700 (PDT) Date: Wed, 26 Aug 2026 23:41:09 +0530 From: Lovekesh Solanki To: Mathias Nyman Cc: Mathieu Fluhr , Michal Pecio , Thorsten Leemhuis , linux-usb@vger.kernel.org, regressions@lists.linux.dev, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Mario Limonciello , Forest , Slavik Dev Subject: Re: [REGRESSION] 6.12.36+: usb: hub: post-resume delayed work triggers > uncorrected MCE / data fabric sync flood on Threadripper 7970X > (bisected to aec11e5f9c45) Message-ID: References: <07435e6b-ee30-4c85-8c8b-0ce3a4ead1d9@leemhuis.info> <20260823174059.46fec036.michal.pecio@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Aug 26, 2026 at 04:40:14PM +0300, Mathias Nyman wrote: > Roothub needs some time to settle as well, but 200ms might be excessive. > > xHC can triggers wake (PME) when a connected USB3 device starts signalling wake, > but port registers changes are not always visible to driver before link training > between roothub and device is successful. > > My educated guess is that 120ms should always be enough for the roothub. > This is also the lecagy msleep() still apparently left in xhci resume > to detect port changes in xhci runtime resume if there are USB3 devices. > That msleep was supposed to be removed now that we got the hub changes. > > This 120ms can probably be further tuned for roothub in some cases, > especially if resume is due to userspace action instead of xHC wake signal (PME). So the patch I sent above unintentionally brought the total hold from hub and xhci side down to 120ms, which worked. And the correct fix would be to bring USB_SS_PORT_U0_WAKE_TIME down to 120ms and clean up the msleep from xhci_resume? I can prepare a patch that addresses both if you'd like. Regards, Lovekesh