Re: [PATCH 5/7] xfs: fix replaying dirent removals into the temporary directory

[Carlos Maiolino <cem@kernel.org>]

On Tue, Sep 08, 2026 at 11:05:37PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> xrep_dir_replay_removename is the function that replays a directory
> entry removal from sc->ip into the temporary directory so that when we
> swap the contents of sc->tempip and sc->ip, the directory is correct.
> LOLLM noticed that we were passing the wrong inode pointer into
> xrep_dir_init_args.  It doesn't make sense to set rd->args.dp to
> rd->args.dp so let's fix this.
> 
> Cc: <stable@vger.kernel.org> # v6.10
> Fixes: 8559b21a64d983 ("xfs: implement live updates for directory repairs")
> Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
> Assisted-by: LOLLM # finding obvious bugs

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> ---
>  fs/xfs/scrub/dir_repair.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/fs/xfs/scrub/dir_repair.c b/fs/xfs/scrub/dir_repair.c
> index 0a3d02d8f04153..82ec5cfad63c59 100644
> --- a/fs/xfs/scrub/dir_repair.c
> +++ b/fs/xfs/scrub/dir_repair.c
> @@ -727,7 +727,7 @@ xrep_dir_replay_removename(
>  	const struct xfs_name	*name,
>  	xfs_extlen_t		total)
>  {
> -	struct xfs_inode	*dp = rd->args.dp;
> +	struct xfs_inode	*dp = rd->sc->tempip;
>  
>  	ASSERT(S_ISDIR(VFS_I(dp)->i_mode));
>  
> 
>