From: Florian Westphal <fw@strlen.de>
To: Henry Martin <bsdhenrymartin@gmail.com>
Cc: pablo@netfilter.org, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_tables: fix pernet use-after-free on UNREGISTER rebroadcast
Date: Thu, 5 Nov 2026 12:58:05 +0100 [thread overview]
Message-ID: <auxvTfxdTgYnZ0Wn@strlen.de> (raw)
In-Reply-To: <20261105114817.3033625-1-bsdhenrymartin@gmail.com>
Henry Martin <bsdhenrymartin@gmail.com> wrote:
>
> + /* netdev_wait_allrefs_any() rebroadcasts NETDEV_UNREGISTER
> + * while waiting for the last references to be dropped; the
> + * netns and its nftables pernet storage may already be torn
> + * down by then.
> + */
> + if (event == NETDEV_UNREGISTER &&
> + READ_ONCE(dev->reg_state) == NETREG_UNREGISTERED)
> + return NOTIFY_DONE;
> +
3x copypaste of same arbitrary conditional :-(
next prev parent reply other threads:[~2026-11-05 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 11:48 [PATCH] netfilter: nf_tables: fix pernet use-after-free on UNREGISTER rebroadcast Henry Martin
2026-11-05 11:58 ` Florian Westphal [this message]
2026-11-05 12:30 ` Pablo Neira Ayuso
2026-11-05 13:15 ` henry martin
2026-11-05 14:09 ` Eric Dumazet
2026-11-05 14:26 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auxvTfxdTgYnZ0Wn@strlen.de \
--to=fw@strlen.de \
--cc=bsdhenrymartin@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox