Re: [PATCH v2] mm/madvise: zap markers from guard regions

["Lorenzo Stoakes (ARM)" <ljs@kernel.org>]

On Fri, Nov 13, 2026 at 10:39:30PM +0100, David Hildenbrand (Arm) wrote:
> >>>  mm/madvise.c | 28 +++++++++++++++++++---------
> >>>  1 file changed, 19 insertions(+), 9 deletions(-)
> >>>
> >>> diff --git a/mm/madvise.c b/mm/madvise.c
> >>> index 0214efd2a014..4f7728583207 100644
> >>> --- a/mm/madvise.c
> >>> +++ b/mm/madvise.c
> >>> @@ -850,6 +850,19 @@ static int madvise_free_single_vma(struct madvise_behavior *madv_behavior)
> >>>  	return 0;
> >>>  }
> >>>
> >>> +static void zap_range(struct madvise_behavior *madv_behavior,
> >>> +		      zap_flags_t flags)
> >>
> >> Two ... ;) But maybe it's consistent like that in the file, didn't check.
> >
> > I'm a bit exhausted, can you or Andrew just fix up whitespace like this on
> > application?
> >
> > It'll be easier when I have the VMA tree.
>
> Yeah, absolutely. I'll let Andrew pick this one.

Thanks! :)

> >>>  	/*
> >>> @@ -1845,6 +1854,7 @@ static bool madvise_batch_tlb_flush(int behavior)
> >>>  	case MADV_DONTNEED:
> >>>  	case MADV_DONTNEED_LOCKED:
> >>>  	case MADV_FREE:
> >>> +	case MADV_GUARD_INSTALL:
> >>
> >> Huh why that change? Not spelled out above.
> >
> > It's just the established way madvise interacts with TLB maintenance.
> >
> > Anything that uses madv_behaviour->tlb has to return true here so
> > madvise_init_tlb() and madvise_finish_tlb() do the right thing.
>
> Ohhh, I see now.
>
> Acked-by: David Hildenbrand (Arm) <david@kernel.org>

Thanks :)

>
> --
> Cheers,
>
> David

--
Cheers, Lorenzo