Re: [PATCH] keys: serialise instantiation against keyctl_chown_key

[Jarkko Sakkinen <jarkko@kernel.org>]

On Sun, Nov 15, 2026 at 02:36:25PM +0200, Jarkko Sakkinen wrote:
> On Sun, Nov 15, 2026 at 02:33:36PM +0200, Jarkko Sakkinen wrote:
> > On Sun, Nov 15, 2026 at 02:30:23PM +0200, Jarkko Sakkinen wrote:
> > > Please review the LLM generated patch yourself at first and write
> > > a commit message thta you can understand yourself.
> > > 
> > > Plus, remove spurious inline comment changes. I'm only then going
> > > to review this.
> > 
> > I.e., I have serious concerns that you might not know what you're
> > doing. Well-formed commit is the way to get evidence on that.
> 
> E.g., if I pick and write proper explanation instead of slop,
> should I call it my own?
> 
> To have a review process, there must be two who think. Otherwise,
> it is just me figuring out all of this; and LLM. You have no role.
> 
> This is also why it is important to write proper commits.

Finally, while not knowing if this is the case, it is irresponsible
as hell to send patches to subsystems like keyrings *if* you don't
understand yourself exactly what you are doing.

Leaf driver mixes up only that leave driver; an uncosidered fix to
a subsystem that is always on  side-effects can do much worse.

Have you considered this?

I'll hold for for v2 :-) Just do the work properly. That's all.

Br, Jarkko