From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Lee Jones <lee@kernel.org>
Cc: Xiubo Li <Li.Xiubo@freescale.com>,
"shenwei.wang@nxp.com" <shenwei.wang@nxp.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 5/8] pwm: fsl-ftm: Enable ipg_clk around regcache_sync() during resume
Date: Fri, 20 Nov 2026 13:02:25 +0100 [thread overview]
Message-ID: <awA2gqJ2c8QlsmRu@monoceros> (raw)
In-Reply-To: <20261105143847.2559586-6-lee@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]
Hello Lee,
On Thu, Nov 05, 2026 at 02:38:07PM +0000, Lee Jones wrote:
> On SoCs with a dedicated IP interface clock (ipg_clk), register accesses
> require ipg_clk to be enabled in addition to the ftm_sys clock managed
> by regmap_mmio. In fsl_pwm_resume(), ipg_clk is only enabled inside the
> channel loop for channels with PWMF_REQUESTED set, so if no channels are
> currently requested, regcache_sync() writes to the hardware registers
> while ipg_clk is disabled.
>
> Enable ipg_clk across fsl_pwm_resume() around regcache_sync(), matching
> fsl_pwm_init().
>
> Fixes: 82a9c55a2bb0 ("pwm: fsl-ftm: Added a dedicated IP interface clock")
> Closes: https://sashiko.dev/#/bug/linux-858851cf-55a9-4776-883c-69c05f3961f2
> Cc: stable@vger.kernel.org
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> drivers/pwm/pwm-fsl-ftm.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c
> index 35406b2e1925..9e5470e2efe6 100644
> --- a/drivers/pwm/pwm-fsl-ftm.c
> +++ b/drivers/pwm/pwm-fsl-ftm.c
> @@ -501,8 +501,13 @@ static int fsl_pwm_resume(struct device *dev)
> {
> struct pwm_chip *chip = dev_get_drvdata(dev);
> struct fsl_pwm_chip *fpc = to_fsl_chip(chip);
> + int ret;
> int i;
>
> + ret = clk_prepare_enable(fpc->ipg_clk);
> + if (ret)
> + return ret;
> +
> for (i = 0; i < chip->npwm; i++) {
> struct pwm_device *pwm = &chip->pwms[i];
>
> @@ -522,6 +527,8 @@ static int fsl_pwm_resume(struct device *dev)
> regcache_cache_only(fpc->regmap, false);
> regcache_sync(fpc->regmap);
>
> + clk_disable_unprepare(fpc->ipg_clk);
> +
> return 0;
Just from looking at the code (i.e. without the commit log available)
it's not obvious why the clk_enable is needed. Can you add a comment and
maybe move the enable call to after the loop?
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-11-20 12:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261105143847.2559586-1-lee@kernel.org>
2026-11-05 14:38 ` [PATCH 1/8] pwm: tegra: Prevent 32-bit period truncation and division by zero Lee Jones
2026-11-05 15:46 ` Uwe Kleine-König
2026-11-18 17:16 ` Lee Jones
2026-11-19 14:44 ` Uwe Kleine-König
2026-11-05 14:38 ` [PATCH 2/8] pwm: mxs: Return early when disabling and fix error-path clock leak Lee Jones
2026-11-05 16:50 ` Frank Li
2026-11-20 12:12 ` Uwe Kleine-König
2026-11-05 14:38 ` [PATCH 3/8] pwm: loongson: Fix 32-bit control register truncation in pwm_loongson_set_polarity() Lee Jones
2026-11-05 14:38 ` [PATCH 4/8] pwm: axi-pwmgen: Enable clocks before accessing hardware registers in probe() Lee Jones
2026-11-05 15:48 ` Uwe Kleine-König
2026-11-05 18:26 ` Lee Jones
2026-11-05 18:26 ` Lee Jones
2026-11-06 13:01 ` Nuno Sá
2026-11-05 14:38 ` [PATCH 5/8] pwm: fsl-ftm: Enable ipg_clk around regcache_sync() during resume Lee Jones
2026-11-20 12:02 ` Uwe Kleine-König [this message]
2026-11-05 14:38 ` [PATCH 6/8] pwm: omap-dmtimer: Handle negative error codes from get_pwm_status() Lee Jones
2026-11-20 11:57 ` Uwe Kleine-König
2026-11-05 14:38 ` [PATCH 7/8] pwm: tiehrpwm: Enable runtime PM before registering PWM chip Lee Jones
2026-11-20 12:06 ` Uwe Kleine-König
2026-11-05 14:38 ` [PATCH 8/8] pwm: img: Unregister PWM chip before disabling runtime PM and clocks Lee Jones
2026-11-20 12:10 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awA2gqJ2c8QlsmRu@monoceros \
--to=ukleinek@kernel.org \
--cc=Li.Xiubo@freescale.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox