From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:56861 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754854AbcHYOm2 (ORCPT ); Thu, 25 Aug 2016 10:42:28 -0400 Subject: Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open To: , Jiri Kosina , Greg Kroah-Hartman References: <20160818135932.219369981@linuxfoundation.org> <20160818135938.484441980@linuxfoundation.org> <0df64efc-85fe-1de7-f15f-233f1e5fdad8@compro.net> <20160824201701.GB2133@kroah.com> <6b0f11af-84a4-ef0c-0033-7a10de189813@compro.net> CC: , , Wim Osterholt From: Jens Axboe Message-ID: Date: Thu, 25 Aug 2016 08:41:26 -0600 MIME-Version: 1.0 In-Reply-To: <6b0f11af-84a4-ef0c-0033-7a10de189813@compro.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 08/25/2016 07:08 AM, Mark Hounschell wrote: > On 08/24/2016 05:11 PM, Jiri Kosina wrote: >> On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: >> >>>> I have a problem with this patch. It only fixes one of the regressions >>>> caused by the original change to the floppy driver. It does not >>>> address the >>>> user land breakage of removing the NODELAY flag checks. >>> >>> Does the same problem also happen in Linus's tree? If not, any hints on >>> the patch that might have fixed it there? >> > > Yes, it does. IMHO the entire patch (between 4.4 and 4.5 that broke user > land multiple ways) should be reverted and a fix for what ever obscure > BUG was supposed to be fixed should be "retried". > >> That's still an unresolved issue, and it's on my list to things to look >> into. >> >> This particular patch though fixes a different issue, and should be >> applied to -stable. >> > > This patch fixes a bug that was introduced to fix "some other obscure > BUG" that has nothing to do whatever with the "physical floppy" device. > And it broke user land in at least 2 ways. All this patch does is revert > part of the original patch so that it is only broke in 1 way to user > land. It should revert the whole thing IMHO. Which patch is this? If that is truly the case, it should be reverted asap. -- Jens Axboe