Re: [PATCH 6.12.y] mptcp: pm: ADD_ADDR rtx: allow ID 0

[Matthieu Baerts <matttbe@kernel.org>]

Hi Sasha,

On 18/05/2026 23:45, Sasha Levin wrote:
> From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
> 
> [ Upstream commit 03f324f3f1f7619a47b9c91282cb12775ab0a2f1 ]
> 
> ADD_ADDR can be sent for the ID 0, which corresponds to the local
> address and port linked to the initial subflow.
> 
> Indeed, this address could be removed, and re-added later on, e.g. what
> is done in the "delete re-add signal" MPTCP Join selftests. So no reason
> to ignore it.
> 
> Fixes: 00cfd77b9063 ("mptcp: retransmit ADD_ADDR when timeout")
> Cc: stable@vger.kernel.org
> Reviewed-by: Mat Martineau <martineau@kernel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Link: https://patch.msgid.link/20260505-net-mptcp-pm-fixes-7-1-rc3-v1-2-fca8091060a4@kernel.org
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> [ relocated the 3-line deletion from net/mptcp/pm.c to net/mptcp/pm_netlink.c ]
> Signed-off-by: Sasha Levin <sashal@kernel.org>
I just noticed that this patch didn't get applied by Greg. I guess
that's similar to other patches: there are conflict after having applied
other patches you sent earlier.

I can look at fixing all that.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.