[PATCH] platform/x86: hp-bioscfg: Support allocations of larger data

[PATCH] platform/x86: hp-bioscfg: Support allocations of larger data

[Mario Limonciello]

Some systems have much larger amounts of enumeration attributes
than have been previously encountered. This can lead to page allocation
failures when using kcalloc().  Switch over to using kvcalloc() to
allow larger allocations.

Fixes: 6b2770bfd6f92 ("platform/x86: hp-bioscfg: enum-attributes")
Cc: stable@vger.kernel.org
Reported-by: Paul Kerry <p.kerry@sheffield.ac.uk>
Closes: https://bugs.debian.org/1127612
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
index 470b9f44ed7aa..af24313d078db 100644
--- a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
+++ b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
@@ -94,8 +94,11 @@ int hp_alloc_enumeration_data(void)
 	bioscfg_drv.enumeration_instances_count =
 		hp_get_instance_count(HP_WMI_BIOS_ENUMERATION_GUID);
 
-	bioscfg_drv.enumeration_data = kzalloc_objs(*bioscfg_drv.enumeration_data,
-						    bioscfg_drv.enumeration_instances_count);
+	if (!bioscfg_drv.enumeration_instances_count)
+		return -EINVAL;
+	bioscfg_drv.enumeration_data = kvcalloc(bioscfg_drv.enumeration_instances_count,
+						sizeof(*bioscfg_drv.enumeration_data), GFP_KERNEL);
+
 	if (!bioscfg_drv.enumeration_data) {
 		bioscfg_drv.enumeration_instances_count = 0;
 		return -ENOMEM;
-- 
2.53.0

Re: [PATCH] platform/x86: hp-bioscfg: Support allocations of larger data

[Mario Limonciello]

On 2/23/2026 10:32 AM, Mario Limonciello wrote:
> Some systems have much larger amounts of enumeration attributes
> than have been previously encountered. This can lead to page allocation
> failures when using kcalloc().  Switch over to using kvcalloc() to
> allow larger allocations.
> 
> Fixes: 6b2770bfd6f92 ("platform/x86: hp-bioscfg: enum-attributes")
> Cc: stable@vger.kernel.org
> Reported-by: Paul Kerry <p.kerry@sheffield.ac.uk>
> Closes: https://bugs.debian.org/1127612
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Add a tag for Paul's test 
(https://lore.kernel.org/platform-driver-x86/b2535142-aaff-4eb0-87bd-34c9f8f16f07@sheffield.ac.uk/T/#m5ae303266e0685309c19c67d2e320a6d42579cd5)

Tested-by: Paul Kerry <p.kerry@sheffield.ac.uk>

> ---
>   drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> index 470b9f44ed7aa..af24313d078db 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> @@ -94,8 +94,11 @@ int hp_alloc_enumeration_data(void)
>   	bioscfg_drv.enumeration_instances_count =
>   		hp_get_instance_count(HP_WMI_BIOS_ENUMERATION_GUID);
>   
> -	bioscfg_drv.enumeration_data = kzalloc_objs(*bioscfg_drv.enumeration_data,
> -						    bioscfg_drv.enumeration_instances_count);
> +	if (!bioscfg_drv.enumeration_instances_count)
> +		return -EINVAL;
> +	bioscfg_drv.enumeration_data = kvcalloc(bioscfg_drv.enumeration_instances_count,
> +						sizeof(*bioscfg_drv.enumeration_data), GFP_KERNEL);
> +
>   	if (!bioscfg_drv.enumeration_data) {
>   		bioscfg_drv.enumeration_instances_count = 0;
>   		return -ENOMEM;

Re: [PATCH] platform/x86: hp-bioscfg: Support allocations of larger data

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]

On Mon, 2026-02-23 at 10:32 -0600, Mario Limonciello wrote:
> Some systems have much larger amounts of enumeration attributes
> than have been previously encountered. This can lead to page allocation
> failures when using kcalloc().  Switch over to using kvcalloc() to
> allow larger allocations.
> 
> Fixes: 6b2770bfd6f92 ("platform/x86: hp-bioscfg: enum-attributes")
> Cc: stable@vger.kernel.org
> Reported-by: Paul Kerry <p.kerry@sheffield.ac.uk>
> Closes: https://bugs.debian.org/1127612
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> index 470b9f44ed7aa..af24313d078db 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> @@ -94,8 +94,11 @@ int hp_alloc_enumeration_data(void)
>  	bioscfg_drv.enumeration_instances_count =
>  		hp_get_instance_count(HP_WMI_BIOS_ENUMERATION_GUID);
>  
> -	bioscfg_drv.enumeration_data = kzalloc_objs(*bioscfg_drv.enumeration_data,
> -						    bioscfg_drv.enumeration_instances_count);
> +	if (!bioscfg_drv.enumeration_instances_count)
> +		return -EINVAL;
> +	bioscfg_drv.enumeration_data = kvcalloc(bioscfg_drv.enumeration_instances_count,
> +						sizeof(*bioscfg_drv.enumeration_data), GFP_KERNEL);
> +

So the kfree() in hp_exit_enumeration_attributes() also needs to become
a kvfree(), right?

Ben.

>  	if (!bioscfg_drv.enumeration_data) {
>  		bioscfg_drv.enumeration_instances_count = 0;
>  		return -ENOMEM;

-- 
Ben Hutchings
Anthony's Law of Force: Don't force it, get a larger hammer.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]