From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
Jaska Uimonen <jaska.uimonen@linux.intel.com>,
Stable <stable@vger.kernel.org>
Subject: Re: [PATCH 3/7] ASoC: SOF: intel: hda: support also devices with 1 and 3 dmics
Date: Fri, 18 Sep 2020 10:10:24 -0500 [thread overview]
Message-ID: <b799ec66-356d-865e-a30b-ca28d5046326@linux.intel.com> (raw)
In-Reply-To: <20200825235040.1586478-4-ranjani.sridharan@linux.intel.com>
On 8/25/20 6:50 PM, Ranjani Sridharan wrote:
> From: Jaska Uimonen <jaska.uimonen@linux.intel.com>
>
> Currently the dmic check code supports only devices with 2 or 4 dmics.
> With other dmic counts the function will return 0. Lately we've seen
> devices with only 1 dmic thus enable also configurations with 1, and
> possibly 3, dmics. Add also topology postfix -1ch and -3ch for new dmic
> configuration.
>
> Signed-off-by: Jaska Uimonen <jaska.uimonen@linux.intel.com>
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
we now have multiple reports of devices with a single microphone where
audio is broken without this patch, e.g.
https://github.com/thesofproject/linux/issues/2451
This patch should be applied to -stable versions all the way to 5.6. It
would be desirable for 5.5 and 5.4 as well but it will not apply
cleanly. It's be trivial to provide a modified patch for these earlier
kernel versions but I don't know what the process might be here?
next parent reply other threads:[~2020-09-18 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200825235040.1586478-1-ranjani.sridharan@linux.intel.com>
[not found] ` <20200825235040.1586478-4-ranjani.sridharan@linux.intel.com>
2020-09-18 15:10 ` Pierre-Louis Bossart [this message]
2020-09-18 15:14 ` [PATCH 3/7] ASoC: SOF: intel: hda: support also devices with 1 and 3 dmics Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b799ec66-356d-865e-a30b-ca28d5046326@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jaska.uimonen@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox