From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AC743876DE; Tue, 10 Mar 2026 11:29:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773142159; cv=none; b=NsBBmW7cExz0lL63ehzl/VBE98/JcllfRyJbJeGTJTPgsTwRkjpehVryRPWc1vO+DElHl0s9XRS9TSRibbU3pRwhsewR6p6/XJBKO63J4c998G14cww/JtyCFxhJNrFjzWbifabze1CudxW2gh9BR/xJ0RCKyP6aewq+QvGJ/1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773142159; c=relaxed/simple; bh=TuNfl08CHhdW20Kq40V82Yl5xAun2GoPmh/hrOD4VAs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pDshHwzwtzhS5dxhI94zKhMnxsM3bqEfNjtFYMrCImwlVj8NU/wH2TL5ZrMPUIkk2W39xo31FuICv1Qy7deYWf1OMFbzb3WDR4zNZcVUamWVgrjVnsgq9XEJvhqITc/0oMD1ipZhBXm0Fj5JR6UwSo4YlXVsuR6o5W3xpqJWWOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dVgyXu/A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dVgyXu/A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A068FC2BC86; Tue, 10 Mar 2026 11:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773142159; bh=TuNfl08CHhdW20Kq40V82Yl5xAun2GoPmh/hrOD4VAs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dVgyXu/AO4Jpytx7mS1JzQjxNVAKg8eLQatPoU673f5HQJ96AeP5GJEwAFUMmbWCe HIdOqZN+c3UEJ81A5JpKDEJxlA7lKFiD/gl3L3MiIHzJ7Ffj9z+BdgPBGVeBeY1daE sigUWeSCkOHMwVH51+DgDC24LiJlAU+LbCjrAMuR6NwYE0U/cqpRjksBX4jMhdUWlT y2Ek9PP3jXPMAqI7Sy5XhUalDCHE033pi/qx0iHbgsHQGm9Kz0ZaaLA5bjg61mqdEE /jETXrBBkXZuGXJe8Ql7+yERAdk+VmoG40rpJTGGwVC2uz07CDWTzpf6a4L24B1q9u KAikwEuUU4xlA== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Mieczyslaw Nalewaj , Andrew Lunn , Luiz Angelo Daros de Luca , Linus Walleij , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.18 247/314] net: dsa: realtek: rtl8365mb: fix rtl8365mb_phy_ocp_write return value Date: Tue, 10 Mar 2026 07:18:26 -0400 Message-ID: X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Mieczyslaw Nalewaj [ Upstream commit 7cbe98f7bef965241a5908d50d557008cf998aee ] Function rtl8365mb_phy_ocp_write() always returns 0, even when an error occurs during register access. This patch fixes the return value to propagate the actual error code from regmap operations. Link: https://lore.kernel.org/netdev/a2dfde3c-d46f-434b-9d16-1e251e449068@yahoo.com/ Fixes: 2796728460b8 ("net: dsa: realtek: rtl8365mb: serialize indirect PHY register access") Signed-off-by: Mieczyslaw Nalewaj Reviewed-by: Andrew Lunn Signed-off-by: Luiz Angelo Daros de Luca Reviewed-by: Linus Walleij Link: https://patch.msgid.link/20260301-realtek_namiltd_fix1-v1-1-43a6bb707f9c@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/dsa/realtek/rtl8365mb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c index 964a56ee16cc9..d06b384d47643 100644 --- a/drivers/net/dsa/realtek/rtl8365mb.c +++ b/drivers/net/dsa/realtek/rtl8365mb.c @@ -769,7 +769,7 @@ static int rtl8365mb_phy_ocp_write(struct realtek_priv *priv, int phy, out: rtl83xx_unlock(priv); - return 0; + return ret; } static int rtl8365mb_phy_read(struct realtek_priv *priv, int phy, int regnum) -- 2.51.0