From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795196404; b=eaEW0+Rml3e85LL3trDuSb4YKAIg+pqmCmTp5Gs/StOKjjWh8bkagq+UbFjL2z8sRwLD /nolLXwslYJWFBlApmNvqhn6PzNeCQ28GXAJGCmaHI3e3sjUqt8WgzLP1qaCtIUGP2e5y CUqXo4WK1KGd4P7a0M4J1NttjvtrBNE3pKTuQ4njTBVfLs+iUlJbczvKSFTUJsvyftWyl YZ9RnzWEJuP9jyv6h+KkKNblGWzM1EChEpPq2eT++D3fEDndjbO53noJfI0IC5sF+IqQ5 PnskFdLq+on+hl4WH71PEm9smj8DqqPMUpqUswoTu1iZC+yC2ADvH9kBkL9NmNwb16Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795196404; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:Content-Language:To:Cc:References:From:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=xJGu1xFkAMb9C3q3yJAs9zMroHTPcUqb/Ezg7HM871w=; b=m3Y1KdFP+aMxtF3YVagsP4ZB/WxPqIy7DtYhJFdUjnSSy2GnWXQoa7/gp9TzJYO4T4fs bgkNaQjc1COmtmYYPTbkqMVyByCAiOnb04sQRbL0ktZLkjaMtvzBa1Hhh2bTHe3bDCmEo XRl8yvKBoDB4X4Q0S55zQE22M8oZYmkrZvkUNcxJbHK0SPz28jLpvJT06QqDaz4K7T9Fl 3t7nutMwpxx7nYohuNXpHYpyuoUCjK1XiK/Ku+LFdd/WzCeaDQxkATFUo7+f2RzssYaVp KIB4KEKsIF/LakY4fKC4ZgQd1XO9eKtVa84FtF4W8jHgtGLyiG1kL7+QXMQl28c9EDg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=gZN90VSi; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0C0D606A338; Fri, 20 Nov 2026 17:40:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=gZN90VSi Received: by smtp.kernel.org (Postfix) with ESMTPSA id A14531F000C0; Fri, 20 Nov 2026 17:39:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795196403; bh=xJGu1xFkAMb9C3q3yJAs9zMroHTPcUqb/Ezg7HM871w=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=gZN90VSiuDuI5QRn3XAgpiV6CaGn0DYsGHMNO4NUtRFJ8ek4jw+EyCbEGPqiDxyyB Ap5i587VTg9CMfrXje5fcdwCf7r60ChdZVB23AaJ2yyFnhamoWPp/2RG/gDDZXJ7TB ft+YKQhZgqPefw0msVYEczY30YPfTZ/gpaH8QPrf/bgOEMnfKiBODI9gjjrV7Yv8bu qniaKPF2+HeuFy/EiK6kLCnTALKaDAXU3O+wP3NnppgUq1fOA6EJ5a1m0WUgGdGVtY LppWlkieuK489WQF95wAiZyjoJbn1EixdjJv5aINttGigP795LUH02clMDsWa3ClGh GQA88QJd1sdMg== Message-ID: Date: Fri, 20 Nov 2026 18:39:52 +0100 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm: flush stale TLB entries before installing a CoW'ed folio Content-Language: en-US To: "David Hildenbrand (Arm)" , Lorenzo Stoakes , "Liam R. Howlett" , "Borislav Petkov (AMD)" , =?UTF-8?Q?Cenk_Y=C4=B1lmaz?= , Zhang Peng , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Andrew Morton , Zi Yan , Matthew Brost , Joshua Hahn , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , Mel Gorman , Sasha Levin , Rik van Riel , Ingo Molnar , Peter Xu , Hugh Dickins , Axel Rasmussen , Johannes Weiner , Michal Hocko , Qi Zheng , Shakeel Butt , Yuanchu Xie , Wei Xu , Baolin Wang , Andrea Arcangeli , Thomas Gleixner Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20261118-file_folio_flush-v1-0-e9e739ed14e0@kernel.org> <20261118-file_folio_flush-v1-1-e9e739ed14e0@kernel.org> From: "Vlastimil Babka (SUSE)" Autocrypt: addr=vbabka@kernel.org; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSNWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBrZXJuZWwub3JnPsLBsAQTAQoAWhYhBKlA1DSZLC6OmRA9UCJPp+fM gqZkBQJqFFy6GxSAAAAAAAQADm1hbnUyLDIuNSsxLjEyLDIsMgIbAwUJGtCBUAULCQgHAwUV CgkICwUWAgMBAAIeBQIXgAAKCRAiT6fnzIKmZJIUEADFx/tREzUImHrEwVHeSvDFmA7tJysI UVrlvrM09E7GIuzphzv7jYmo8n3ANpCczLEVr4G0syYQdTigaZgv3+FQDIIzhKih1IHhu1Ei XHlywNWKnQxxQEUNi5Mwx43wQz5XVw9F1A7gtKBKNtfogO511hAbrzagrYajyQacEJ/+sfhZ 9Da8ltHIXD8pcYaHUfQgEusCgmEd9+KrUwrTbckFKmYq5chuE6yJ4J0EmWknL096jIE6CnzF FRslQ3B1UKDjxVsm1ZHfir5NeWszLkTvGFsddFaWTgh8UycESG6VQzKXjjewXu2pG7YQYRpj QKm1W5X2TkwWkXRBZTmfmbhxIUMh3+zf5wQ463rSmDN/8v81tdqBtAW6rH/kzg1GvkaTHXn0 507yEHFzBksk2viAuIxxr7km8+/KARYLIdGtx30EG8cKzAUZOK6WqxtNCsXUJNrVE8CWrCaD icoNu7Fs1c5hmPHdSTnU48ce67449DdnO4neLSNhRiGlMHJgfJUmgrxu/hcYeOZ3haWmEQ2w uW1Mh01OHi8QZHCEyAbABrPs9GUgccc/4eYXX9hIgxfSkYzn8f+8NuIFPWl/0uTvjgqU29FQ SbzOLxHq9439Ox40G5mS5eZXRGxITYR+6TXvRGI6P/264jvflnr/pDGUttaikU+0W+1uxgKH cmYbEc7ATQRbGTU1AQgAn0H6UrFiWcovkh6EXVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQ La1PQDUi6j00ChlcR66g9/V0sPIcSutacPKfdKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMh FmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCTsTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sf bAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZOrIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq +aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahKtQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4n jQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJksLo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8A CgkQIk+n58yCpmS2PA//bqN1LfcotmArgElsa+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKY HR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVd SXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi 4U9F/trLten/x7bpphDSnDMKJtITbtzATT1Dq7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O4 0PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwgBF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O 2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9YplavCMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/P wIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dq NcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudLvPA/SK8sKoM01IRxSihev/S/5WLazXB1PGem OCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLV jXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4pYekxJujNeEDkUlky0Y= In-Reply-To: <20261118-file_folio_flush-v1-1-e9e739ed14e0@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/18/26 10:20, David Hildenbrand (Arm) wrote: > Zapping PTEs in zap_pte_range() defers the TLB flush until after dropping > the PTL for clean page-cache folios. > > A concurrent write fault in a MAP_PRIVATE mapping can then CoW the > page-cache folio and install a new anon folio without a prior TLB > flush: > > CPU0 CPU1 > LOAD(ADDR) > -> #PF > installs R/O PTE -> A > fuse_open() > -> invalidate_inode_pages2() > -> zap_pte_range() > clears R/O PTE > // delayed flush > // Other CPUs (incl CPU0) still cache ADDR -> A > STORE(ADDR) > -> #PF > do_cow_fault() > copies A to B, installs R/W PTE -> B > // no TLB flush: PTE was none > > CPUs with stale TLB entries will still read from the old folio while writes > go to the new folio, until the TLB is flushed. > > We really must process pending TLB flushes if we are not faulting the > same folio back in. > > Fix it by flushing the TLB before installing an anon (CoW'ed) folio in > set_pte_range() if a TLB flush is pending. Zapping itself stays as fast > as before. > > Other faults are not affected: unmap_mapping_*() users only remove > folios from the page-cache after their own TLB flush, so until then, a > refault maps the same folio again. The exception is a concurrent > invalidation that removes the already-unmapped folio from the > page-cache before the zapper flushed the TLB; that is an unlikely corner > case that we'll not handle for now. > > Note that we don't care about MADV_DONTNEED followed by a new read > fault, as MADV_DONTNEED only guarantees its semantics once the operation > completed. CoW faults will flush the TLB either way. > > For example, imagine that MADV_DONTNEED zaps a page-cache folio and > doesn't flush the TLB (but still holds a reference). If the page-cache > replaces the folio, a new read fault might map the new folio without > flushing the TLB. That's okay, as MADV_DONTNEED did not complete yet. > Same applies to MADV_DONTNEED of CoW'ed folios when re-faulting the > page-cache folio. > > Memory reclaim, which removes folios from the page-cache before performing > its own batched TLB flush, will be handled separately. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Reported-by: Cenk Yılmaz > Debugged-by: Cenk Yılmaz > Cc: stable@vger.kernel.org > Signed-off-by: David Hildenbrand (Arm) Reviewed-by: Vlastimil Babka (SUSE) > --- > mm/memory.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/memory.c b/mm/memory.c > index d2f48d78b0d7b..e1d9759e6fde1 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5888,6 +5888,12 @@ void set_pte_range(struct vm_fault *vmf, struct folio *folio, > /* copy-on-write page */ > if (write && !(vma->vm_flags & VM_SHARED)) { > VM_BUG_ON_FOLIO(nr != 1, folio); > + /* > + * Concurrent zapping might have dropped the PTL but not flushed > + * the TLB yet. Flush before installing a new folio. > + */ > + if (mm_tlb_flush_pending(vma->vm_mm)) > + flush_tlb_page(vma, addr); > folio_add_new_anon_rmap(folio, vma, addr, RMAP_EXCLUSIVE); > folio_add_lru_vma(folio, vma); > } else { >