From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61C8D3803E4 for ; Fri, 20 Mar 2026 09:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773999572; cv=none; b=tq4UcgNSPq3bgWz2f+IWvu/iAonT+Q7WvPX/T+WVCmpwjf7Qdfd7vicrSElBBD05BlfWznUNKaTtpPASNan0jUzNSCX9gCVmLMBdVBXgB+g8v17MAQrqWJZ+etgUsBQwccLw020ENH/jFHzmVtdJdnTZz3P8oBwH3DIFygm4V0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773999572; c=relaxed/simple; bh=0sstqU3fJ4IUi2S+H3VRr6xcvwvgQHXGoAH2vmDu0Mo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hg+hSTQqAJp01tRWQ4gnEr4kbdU9Wphso5ecuHY3sHZ8A4+ALILWO8ptNuZqKTZuCW2VPmlCphacHT9fV04TAFMsxRUseadcUVO71DjK8WDXFRGzatrfIHR+8VOGV3uZOQMq6NpHzpyVq5Ktw3FjLGLrrv/ZiorVEKf0RdFGCcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VCeqWgiX; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VCeqWgiX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773999570; x=1805535570; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0sstqU3fJ4IUi2S+H3VRr6xcvwvgQHXGoAH2vmDu0Mo=; b=VCeqWgiXAf6HMSJ8fW4tU0lJSvmyymM2LmfSDYsHEZok0y3o43soPBqo xK6CEfpXwdaovqcl4QfCDZ3Cxk+MV7XADhGJNHHJM4mxlDW/Lf1F5ukZq D6pRu5ocdBhwaQ1/5BHlMEp6x3Ox6t0k4wEqZJbuMeaQNKBAW7ZmZ7lh8 lnc4PNOBqRVjl0ZpUVQu1+AjW73beVFrHXqUjlynCfIuJjePkX+VZW1GK YI8uvZBggrICT0iDDNtj7B+NL4y6SY7Qps+VUKmdI/I5mXO8m07bNn03Y cAsKtCm+EQCgaqTfG98seGFddN5SEwjF7DxnJEKWGP7Xpi5Kg8a4IhAYW g==; X-CSE-ConnectionGUID: pgweN31eRF2nFryoPFVMLg== X-CSE-MsgGUID: OtSLvaLeTfup1nqzpV8jWA== X-IronPort-AV: E=McAfee;i="6800,10657,11734"; a="85783856" X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="85783856" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 02:39:29 -0700 X-CSE-ConnectionGUID: nAObGmK6TkKxwuNer5WDUw== X-CSE-MsgGUID: NUMW7+4sR5W0nYldGQ80Eg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="228175937" Received: from soc-5cg4396xfb.clients.intel.com (HELO [172.28.180.189]) ([172.28.180.189]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 02:39:26 -0700 Message-ID: Date: Fri, 20 Mar 2026 10:39:24 +0100 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6.1.y 3/3] ice: reintroduce retry mechanism for indirect AQ To: Sasha Levin , stable@vger.kernel.org Cc: Jakub Staniszewski , Michal Schmidt , Aleksandr Loktionov , Przemek Kitszel , Paul Menzel , Rinitha S , Tony Nguyen References: <2026031701-reapprove-dollar-1839@gregkh> <20260318000947.379271-1-sashal@kernel.org> <20260318000947.379271-3-sashal@kernel.org> Content-Language: pl, en-US From: Dawid Osuchowski Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20260318000947.379271-3-sashal@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-03-18 1:09 AM, Sasha Levin wrote: > From: Jakub Staniszewski > > [ Upstream commit 326256c0a72d4877cec1d4df85357da106233128 ] > > Add retry mechanism for indirect Admin Queue (AQ) commands. To do so we > need to keep the command buffer. > > This technically reverts commit 43a630e37e25 > ("ice: remove unused buffer copy code in ice_sq_send_cmd_retry()"), > but combines it with a fix in the logic by using a kmemdup() call, > making it more robust and less likely to break in the future due to > programmer error. > > Cc: Michal Schmidt > Cc: stable@vger.kernel.org > Fixes: 3056df93f7a8 ("ice: Re-send some AQ commands, as result of EBUSY AQ error") > Signed-off-by: Jakub Staniszewski > Co-developed-by: Dawid Osuchowski > Signed-off-by: Dawid Osuchowski > Reviewed-by: Aleksandr Loktionov > Reviewed-by: Przemek Kitszel > Reviewed-by: Paul Menzel > Tested-by: Rinitha S (A Contingent worker at Intel) > Signed-off-by: Tony Nguyen > Signed-off-by: Sasha Levin Tested-by: Dawid Osuchowski Regression tested on real hardware (E810-C for SFP) on top of kernel version: 6.1.167-rc1. No errors/warnings in dmesg, ethtool -m works correctly. Done after applying all the patches in this series, recompiling and reloading the ice module. Thanks ~Dawid :)