From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>,
linux-watchdog@vger.kernel.org
Cc: stable@vger.kernel.org, Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Daniel Lezcano <daniel.lezcano@kernel.org>
Subject: Re: [PATCH] watchdog: s32g_wdt: remove incorrect options in watchdog_info struct
Date: Tue, 5 May 2026 09:54:38 +0200 [thread overview]
Message-ID: <c22b2fc2-c10e-4afd-ad9c-bc43df820655@oss.qualcomm.com> (raw)
In-Reply-To: <20260505024409.60301-1-enelsonmoore@gmail.com>
On 5/5/26 04:44, Ethan Nelson-Moore wrote:
> The s32g_wdt driver uses two incorrect constants in the options field
> of its watchdog_info struct. This bit mask should contain WDIOF_*
> constants, but the driver uses two WDIOC_* ioctl constants (in addition
> to correct WDIOF_* constants). This causes many incorrect bits to be
> set in the bit mask. The functionality indicated by these ioctl
> constants is supported by all drivers using the watchdog framework, so
> this patch simply removes them.
>
> Fixes: bd3f54ec559b ("watchdog: Add the Watchdog Timer for the NXP S32 platform")
> Cc: stable@vger.kernel.org # 6.18+
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
Acked-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
next prev parent reply other threads:[~2026-05-05 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 2:44 [PATCH] watchdog: s32g_wdt: remove incorrect options in watchdog_info struct Ethan Nelson-Moore
2026-05-05 7:54 ` Daniel Lezcano [this message]
2026-05-05 13:16 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c22b2fc2-c10e-4afd-ad9c-bc43df820655@oss.qualcomm.com \
--to=daniel.lezcano@oss.qualcomm.com \
--cc=daniel.lezcano@kernel.org \
--cc=enelsonmoore@gmail.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox