From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>, stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915/psr: Do not use pipe_src as borders for SU area
Date: Fri, 27 Mar 2026 13:55:49 +0200 [thread overview]
Message-ID: <c2900e8eea468da57356e5d6472ea09a22553446@intel.com> (raw)
In-Reply-To: <20260327114553.195285-1-jouni.hogander@intel.com>
On Fri, 27 Mar 2026, Jouni Högander <jouni.hogander@intel.com> wrote:
> @@ -2866,6 +2867,9 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
> struct intel_crtc_state *crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
> struct intel_plane_state *new_plane_state, *old_plane_state;
> struct intel_plane *plane;
> + struct drm_rect display_area = { .x1 = 0, .y1 = 0,
> + .x2 = crtc_state->hw.adjusted_mode.crtc_hdisplay,
> + .y2 = crtc_state->hw.adjusted_mode.crtc_vdisplay};
Nitpick, following the kernel style here actually improves clarity.
struct drm_rect display_area = {
.x1 = 0,
.y1 = 0,
.x2 = crtc_state->hw.adjusted_mode.crtc_hdisplay,
.y2 = crtc_state->hw.adjusted_mode.crtc_vdisplay,
};
BR,
Jani.
--
Jani Nikula, Intel
prev parent reply other threads:[~2026-03-27 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 11:45 [PATCH] drm/i915/psr: Do not use pipe_src as borders for SU area Jouni Högander
2026-03-27 11:55 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2900e8eea468da57356e5d6472ea09a22553446@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox