From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:36553 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725741AbeHAEAY (ORCPT ); Wed, 1 Aug 2018 00:00:24 -0400 Subject: Re: [PATCH] drm/i915/gvt: move intel_runtime_pm_get out of spin_lock in stop_schedule To: Greg KH Cc: intel-gvt-dev@lists.freedesktop.org, stable@vger.kernel.org, Xiong Zhang References: <1533031546-29178-1-git-send-email-hang.yuan@linux.intel.com> <20180731150922.GA13018@kroah.com> From: Hang Yuan Message-ID: Date: Wed, 1 Aug 2018 10:12:53 +0800 MIME-Version: 1.0 In-Reply-To: <20180731150922.GA13018@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 07/31/2018 11:09 PM, Greg KH wrote: > On Tue, Jul 31, 2018 at 06:05:46PM +0800, hang.yuan@linux.intel.com wrote: >> From: Hang Yuan >> >> pm_runtime_get_sync in intel_runtime_pm_get might sleep if i915 >> device is not active. When stop vgpu schedule, the device may be >> inactive. So need to move runtime_pm_get out of spin_lock/unlock. >> >> Fixes: b24881e0b0b6("drm/i915/gvt: Add runtime_pm_get/put into gvt_switch_mmio >> Signed-off-by: Hang Yuan >> Signed-off-by: Xiong Zhang >> --- >> drivers/gpu/drm/i915/gvt/mmio_context.c | 2 -- >> drivers/gpu/drm/i915/gvt/sched_policy.c | 3 +++ >> 2 files changed, 3 insertions(+), 2 deletions(-) > > > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > for how to do this properly. > > > Thank you for the guide. I misunderstood the option 1. Regards, Henry