From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Hans van Kranenburg <hans@knorrie.org>,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
x86@kernel.org, sstabellini@kernel.org, hpa@zytor.com,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
stable@vger.kernel.org
Subject: Re: [PATCH v3] xen: Fix x86 sched_clock() interface for xen
Date: Wed, 16 Jan 2019 16:29:31 +0100 [thread overview]
Message-ID: <c426f0a5-59bf-2ccb-6afd-39990a9fddac@suse.com> (raw)
In-Reply-To: <71f7d41b-1822-d0b5-a28a-b10172bc5746@oracle.com>
On 16/01/2019 16:07, Boris Ostrovsky wrote:
> On 1/16/19 9:33 AM, Juergen Gross wrote:
>> On 16/01/2019 14:17, Boris Ostrovsky wrote:
>>> On Wed, Jan 16, 2019 at 08:50:13AM +0100, Juergen Gross wrote:
>>>
>>>> @@ -1650,13 +1650,14 @@ void xen_callback_vector(void)
>>>> xen_have_vector_callback = 0;
>>>> return;
>>>> }
>>>> - pr_info("Xen HVM callback vector for event delivery is
>>>> enabled\n");
>>>> + if (!silent)
>>>> + pr_info("Xen HVM callback vector for event
>>>> delivery is enabled\n");
>>> How about replacing pr_info() with pr_info_once()?
>> What a nice and simple idea!
>>
>> Extra patch or V4?
>>
>
>
> I can add this while committing, I don't think it's worth a whole new patch.
>
> One outstanding question I have is whether anything needs to be added to
> the commit message (Thomas had some questions)
He didn't react to my explanation. I'm interpreting that as him being
fine with my explanation, which I believe is not suitable to be added
to the commit message.
Juergen
next prev parent reply other threads:[~2019-01-16 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 12:44 [PATCH v3] xen: Fix x86 sched_clock() interface for xen Juergen Gross
2019-01-14 13:54 ` Boris Ostrovsky
2019-01-16 0:26 ` Hans van Kranenburg
2019-01-15 10:43 ` Thomas Gleixner
2019-01-15 11:03 ` Juergen Gross
2019-01-16 0:24 ` Hans van Kranenburg
2019-01-16 7:50 ` Juergen Gross
2019-01-16 13:17 ` Boris Ostrovsky
2019-01-16 14:33 ` Juergen Gross
2019-01-16 15:07 ` Boris Ostrovsky
2019-01-16 15:29 ` Juergen Gross [this message]
2019-01-16 18:29 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c426f0a5-59bf-2ccb-6afd-39990a9fddac@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hans@knorrie.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox