From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, "Ewan D . Milne" <emilne@redhat.com>,
Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.com>, Christoph Hellwig <hch@lst.de>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, stable@vger.kernel.org
Subject: Re: [PATCH V4 0/2] block/scsi/dm-rq: fix leak of request private data in dm-mpath
Date: Sun, 4 Aug 2019 20:42:26 -0700 [thread overview]
Message-ID: <c7bd89e5-6fa9-2b3c-94f5-ca7ff9004e6a@kernel.dk> (raw)
In-Reply-To: <20190725020500.4317-1-ming.lei@redhat.com>
On 7/24/19 7:04 PM, Ming Lei wrote:
> Hi,
>
> When one request is dispatched to LLD via dm-rq, if the result is
> BLK_STS_*RESOURCE, dm-rq will free the request. However, LLD may allocate
> private data for this request, so this way will cause memory leak.
>
> Add .cleanup_rq() callback and implement it in SCSI for fixing the issue,
> since SCSI is the only driver which allocates private requst data in
> .queue_rq() path.
>
> Another use case of this callback is to free the request and re-submit
> bios during cpu hotplug when the hctx is dead, see the following link:
>
> https://lore.kernel.org/linux-block/f122e8f2-5ede-2d83-9ca0-bc713ce66d01@huawei.com/T/#t
Applied for 5.4, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-08-05 3:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 2:04 [PATCH V4 0/2] block/scsi/dm-rq: fix leak of request private data in dm-mpath Ming Lei
2019-07-25 2:04 ` [PATCH V4 1/2] blk-mq: add callback of .cleanup_rq Ming Lei
2019-07-25 2:05 ` [PATCH V4 2/2] scsi: implement .cleanup_rq callback Ming Lei
2019-07-30 0:44 ` [PATCH V4 0/2] block/scsi/dm-rq: fix leak of request private data in dm-mpath Ming Lei
2019-08-05 0:55 ` Ming Lei
2019-08-05 3:42 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7bd89e5-6fa9-2b3c-94f5-ca7ff9004e6a@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=emilne@redhat.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).