From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mailout.easymail.ca ([64.68.200.34]:52641 "EHLO
        mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726795AbeJICm2 (ORCPT
        <rfc822;stable@vger.kernel.org>); Mon, 8 Oct 2018 22:42:28 -0400
Subject: Re: [PATCH] usbip: vhci_hcd: check port number before using
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Valentina Manea <valentina.manea.m@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        syzbot+600b03e0cf1b73bb23c4@syzkaller.appspotmail.com,
        stable <stable@vger.kernel.org>, Shuah Khan <shuah@kernel.org>
References: <20181008191913.11527-1-sudip.mukherjee@codethink.co.uk>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <c7da9adc-3cb3-c5a6-519c-ba4440897c28@kernel.org>
Date: Mon, 8 Oct 2018 13:28:57 -0600
MIME-Version: 1.0
In-Reply-To: <20181008191913.11527-1-sudip.mukherjee@codethink.co.uk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Hi Sudip,

On 10/08/2018 01:19 PM, Sudip Mukherjee wrote:
> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> 
> The port number is checked and it just prints an error message but it
> still continues to use the invalid port. And as a result it accesses
> memory which is not its resulting in  BUG report from KASAN.

Yes there is an issue with out of bounds access. But this isn't the
right fix.

> 
> Reported-by: syzbot+600b03e0cf1b73bb23c4@syzkaller.appspotmail.com
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

I sent in a fix for this last Friday.

https://patchwork.kernel.org/patch/10628833/

thanks,
-- Shuah