From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5752727FB34 for ; Fri, 6 Jun 2025 10:00:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749204024; cv=none; b=ahbBvJaUL55Rt7Qpd56NydU76pV4Mf1P29e/tx15OCW50BGSXlBvRS5AbDM2EY4RFYlHxOBhC4mwbKQMxz8Km+YxLRpOqxvlpkZxft0TWHlqcvyXMzxMqXO2LCN9w6QcPokhbQlwEaAOO/1Fq/K2a7e1WLR5/HksZuoe620LLm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749204024; c=relaxed/simple; bh=3a+WQLGp4elFYZvrRecz8JZgfyQKKlirEzi3m1GN03Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=taiQwoH5fvbUhJb0teC2TCHyc4mlVkK9zpxBQq8S2CF89Kn9o1ZRtpkR6zN8cPWwXDO9W996R4UPYssEXFJsxf8Onv3jwIzlVQ8ReWXdpR+4mMOZn9aTLg2KI8VxRTRFg7hobjTamG3GQDcBBwjmKPMjVT/5OJGEbb9wFdJRC78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=o/iDplID; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o/iDplID" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3a36e090102so1157398f8f.2 for ; Fri, 06 Jun 2025 03:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749204020; x=1749808820; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Wm5Ysxp6GbjttnpPxWFZX/i14ZJHHqOtrosH3lsbGA=; b=o/iDplIDx5jpp9nUY2jflHw+xk5xcd4ILsUh9OwOBhQIfOtjZsVTBUBYuJNnaNfcg2 06Asjz7Ndy39AphhmVt1np1DmZWrr2jXcgHeE7WTJgYuTl1bqdZAGqp4frdiG+DAP9YF aKhckTHYjKjt6h+kX2xeHNIP6grjHdSj+APQMCikU7wOWHAoEWE7bWVHcD7KR+fm9Ox8 bSxsTXZrETAtNQGEE6gq+6YX4cmxNKMRwtG+NNsMMD9NVtclnswI+tnv2UnboQaZIplJ iE3ag+NBvbrzR5vOOp0pVUJ0+ES6BigyPtNAM8dU3SrNhM28KzjyViIdT1IGYOipxVe+ 5Eig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749204020; x=1749808820; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Wm5Ysxp6GbjttnpPxWFZX/i14ZJHHqOtrosH3lsbGA=; b=h/retvyAUDynAQ8qjC7QmBaeO7zO5reCcR3eiT0zrQKpCmntdsPU8aiCBQI+GPHHQ2 oywXpsqVBR361EIje4pjjE++tgbQ8pE126sct7aet4AUOqKSDAs1iPsVY6ymWSsnle+w jOt+zrrlq2RXIbOWAz+IwE5okroOW8Zvej70G9qFVj8GD/xaVrcN2BOmUZImTULKILCW 2WBLSIdMKmcTsDl+g9A+EhVHcTk/kAgKZ3vs4h25d7J7IDiX0aEbDTbrzbomIS/XwL3A mIqqHVjP/Lwd++mQuKETX5DC573mIOj5VxhMQLDcvMfl6AYqrXgnhbYkv+SXQqNiS1RF 53Ng== X-Forwarded-Encrypted: i=1; AJvYcCVnmAHJsQFSfKg1Opk9i5u9I3KVvVNpJanJztB675ra7FJ/Y1GyA7hHwQoGktWviH4rKiHkZho=@vger.kernel.org X-Gm-Message-State: AOJu0YyQ7vm5DF1qI8AnqLaTaPUDUUtA5uF9hWbytzNbW0B3ryTX8Txv BEIFFXDPGtPj5eDQJERxlQqoe+beYoHDJ0T70ed5vrUvu3gE7Uk1WYUhDttKZVBrI84= X-Gm-Gg: ASbGncu1lqjnz+CmVn5WeGXn5BFEalFgewmlGWU5Hm7geHQHwtAl55YK7GFqP92/UPu npuYY0qLY9uW5o+OcOcnTtmbDYPAbSHDje6Y0bGFYloYy1ewvKzQcqG2DV1PUivW9vxFMk4aD/P KcsI2Igo0fl3lfgzov8ejNtJyVbYIAkm2u1WkUGKEtV8myY/B/oSL4EJ076RQJdn2cKQAGK/+Rv jVLXjy0KtbTpaa6XOYLfAV+eYj7eCPPa0tCPz/o0+5SyzU4FS+A55kmb7FrFdsfc6h0u4K8HSR5 rpbV29ZVFI0SkEu94TUduk9GUUxlPaE0+Ww8YQeRxj0PowTjilfJYizSnDnbQ3LfHmj5lQ== X-Google-Smtp-Source: AGHT+IHtw37a7aLpgY1NgIlSmAhbyHbRMRvllHSnmnalrMLkUdNldLsfg2cqEgFo08aK/ax73zNvkw== X-Received: by 2002:a05:6000:25c5:b0:3a4:df80:7284 with SMTP id ffacd0b85a97d-3a53188a553mr2530102f8f.1.1749204020520; Fri, 06 Jun 2025 03:00:20 -0700 (PDT) Received: from [192.168.1.221] ([5.30.189.74]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a5324621a4sm1347436f8f.88.2025.06.06.03.00.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 03:00:18 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 13:00:14 +0300 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dmaengine: mediatek: Fix a flag reuse error in mtk_cqdma_tx_status() To: Qiu-ji Chen Cc: sean.wang@mediatek.com, vkoul@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, stable@vger.kernel.org, kernel test robot References: <20250606071709.4738-1-chenqiuji666@gmail.com> Content-Language: en-US From: Eugen Hristev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/6/25 12:14, Qiu-ji Chen wrote: >> On 6/6/25 10:17, Qiu-ji Chen wrote: >>> Fixed a flag reuse bug in the mtk_cqdma_tx_status() function. >> If the first spin_lock_irqsave already saved the irq flags and disabled >> them, would it be meaningful to actually use a simple spin_lock for the >> second lock ? Or rather spin_lock_nested since there is a second nested >> lock taken ? >> >> Eugen >> > > Hello Eugen, > > Thanks for helpful suggestion. The modification has been submitted in > patch v2 as discussed. > > Best regards, > Qiu-ji Chen You are welcome, but in fact I suggested two alternatives. Any reason you picked this one instead of the other ?