From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Anup Kulkarni <anup.kulkarni@oss.qualcomm.com>,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
johan+linaro@kernel.org, dianders@chromium.org,
quic_ptalari@quicinc.com, quic_zongjian@quicinc.com,
quic_jseerapu@quicinc.com, quic_vdadhani@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Cc: mukesh.savaliya@oss.qualcomm.com,
viken.dadhaniya@oss.qualcomm.com, stable@vger.kernel.org
Subject: Re: [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode
Date: Tue, 16 Sep 2025 15:12:16 +0100 [thread overview]
Message-ID: <ca511d42-0381-41d1-bea0-0d766e04f9f4@linaro.org> (raw)
In-Reply-To: <20250916093957.4058328-1-anup.kulkarni@oss.qualcomm.com>
On 16/09/2025 10:39, Anup Kulkarni wrote:
> If uart_get_rs485() fails, the driver returns without detaching
> the PM domain list.
>
> Fix the error handling path in uart_get_rs485_mode() to ensure the
> PM domain list is detached before exiting.
>
> Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms")
> Cc: stable@vger.kernel.org
> Signed-off-by: Anup Kulkarni <anup.kulkarni@oss.qualcomm.com>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 9c7b1cea7cfe..0fc0f215b85c 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -1928,7 +1928,7 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
>
> ret = uart_get_rs485_mode(uport);
> if (ret)
> - return ret;
> + goto error;
>
> devm_pm_runtime_enable(port->se.dev);
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2025-09-16 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 9:39 [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode Anup Kulkarni
2025-09-16 14:12 ` Bryan O'Donoghue [this message]
2025-09-17 11:15 ` Greg KH
2025-09-18 6:34 ` Anup Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca511d42-0381-41d1-bea0-0d766e04f9f4@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=anup.kulkarni@oss.qualcomm.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=quic_jseerapu@quicinc.com \
--cc=quic_ptalari@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=quic_zongjian@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox