From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0675C77B73 for ; Thu, 20 Apr 2023 15:36:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230483AbjDTPgU (ORCPT ); Thu, 20 Apr 2023 11:36:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231928AbjDTPgT (ORCPT ); Thu, 20 Apr 2023 11:36:19 -0400 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 388E44C08 for ; Thu, 20 Apr 2023 08:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vxTVIFedeaDzSeEN8LdVzAH2WZ08uoCdcejVk2bRSig=; b=J4bKaRgHrDJmsY0+rG+w3fGmT3 2Hv3bNBQfVIUql3wgIpoLBgGI4rxML79SH1Nn41NFQ60/wFQwtrfR8s2nTGS8pRYFA+jBWZ9gIt4C 6xkJGq68ZuBIIkgZg73vVvfcWw1SevMXWrB2J4p91pzy6M8kUZPvp4r1DXV7EtBK7ipPB19alCjbq GTfmS+McSON1H3g2c2bmYTo+OXpB716lBPSFPOOKSzfrAchuzOSVM7elzolmkohq0ahMP+L3BkHuX wqptzNGlJ6F+d7nrfs5UvaO2ekVcixQWqNsPqKVVnGKItDuhJThsr30JITPgpOQFKvn/MITv/y52d yfYUcUKQ==; Received: from 201-92-79-199.dsl.telesp.net.br ([201.92.79.199] helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1ppWKP-0072VA-WA; Thu, 20 Apr 2023 17:36:11 +0200 Message-ID: Date: Thu, 20 Apr 2023 12:36:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 6.1.y] drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes Content-Language: en-US To: "gregkh@linuxfoundation.org" Cc: "Deucher, Alexander" , "stable@vger.kernel.org" , "sashal@kernel.org" , "amd-gfx@lists.freedesktop.org" , "Zhu, James" , "Liu, Leo" , "kernel@gpiccoli.net" , "kernel-dev@igalia.com" References: <20230418221522.1287942-1-gpiccoli@igalia.com> <9b9a28f5-a71f-bb17-8783-314b1d30c51f@igalia.com> <94b63d19-4151-c294-50eb-c325ea9c699f@igalia.com> From: "Guilherme G. Piccoli" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 20/04/2023 12:02, gregkh@linuxfoundation.org wrote: >> [...] >>> Which "one" are you referring to here? >>> >>> confused, >>> >>> greg k-h >> >> This one, sent in this email thread. > > I don't have "this email thread" anymore, remember, some of us get > thousand+ emails a day... I don't really understand the issue to be honest, we are talking in the very email thread! The email was sent April/18, it's not old or anything. But in any case, for reference, this is the original email from the lore archives: https://lore.kernel.org/stable/20230418221522.1287942-1-gpiccoli@igalia.com/ > >> The title of the patch is "drm/amdgpu/vcn: Disable indirect SRAM on >> Vangogh broken BIOSes", target is 6.1.y and (one of the) upstream >> hash(es) is 542a56e8eb44 heh > > But that commit says it fixes a problem in the 6.2 tree, why is this > relevant for 6.1.y? > That is explained in the email and the very reason for that, is the duplicate hashes we are discussing here. The fix commit in question points the "Fixes:" tag to 82132ecc5432 ("drm/amdgpu: enable Vangogh VCN indirect sram mode"), which appears to be in 6.2 tree, right? But notice that 9a8cc8cabc1e ("drm/amdgpu: enable Vangogh VCN indirect sram mode") is the *same* offender and..is present on 6.1 ! In other words, when I first wrote this fix, I just checked the tree quickly and came up with "Fixes: 82132ecc5432", but to be thorough, I should have pointed the fixes tag to 9a8cc8cabc1e, to pick it on 6.1.y. tl;dr: the offender is present on 6.1.y, but this fix is not, hence I'm hereby requesting the merge. Some backport/context adjustment was necessary and it was properly tested in the Steam Deck. Thanks, Guilherme