From: Dave Hansen <dave.hansen@intel.com>
To: Xin Li <xin@zytor.com>, Sohil Mehta <sohil.mehta@intel.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, peterz@infradead.org,
andrew.cooper3@citrix.com, nikunj@amd.com,
thomas.lendacky@amd.com, seanjc@google.com,
stable@vger.kernel.org
Subject: Re: [PATCH v1] x86/smp: Set up exception handling before cr4_init()
Date: Mon, 9 Feb 2026 07:14:38 -0800 [thread overview]
Message-ID: <cc4eae31-e4fd-4052-939f-57b203c53927@intel.com> (raw)
In-Reply-To: <5E3DA211-BD18-459F-ADDE-63E24E8C8BEA@zytor.com>
On 2/9/26 00:16, Xin Li wrote:
> I’m not sure if Dave also wants to make BSP/AP boot code symmetric
> at the same time 😉
It's perfectly fine to do things one bit at a time. In this case,
cr4_init() is does two different things underneath the covers depending
on the state of CR pinning. If CR pinning as a feature is kicked out
influencing the early CPU boot code at _all_, then it certainly helps
the goal if making the AP/BSP code more symmetric.
So I very much prefer doing things one bit at a time, if we can.
next prev parent reply other threads:[~2026-02-09 15:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 18:50 [PATCH v1] x86/smp: Set up exception handling before cr4_init() Xin Li (Intel)
2026-02-06 19:19 ` Dave Hansen
2026-02-08 19:02 ` Xin Li
2026-02-09 7:28 ` Sohil Mehta
2026-02-09 8:16 ` Xin Li
2026-02-09 15:14 ` Dave Hansen [this message]
2026-02-10 0:18 ` Sohil Mehta
2026-02-10 1:13 ` Dave Hansen
2026-02-10 3:11 ` Xin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc4eae31-e4fd-4052-939f-57b203c53927@intel.com \
--to=dave.hansen@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=sohil.mehta@intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox