From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
alsa-devel@alsa-project.org,
Pan Xiuli <xiuli.pan@linux.intel.com>,
stable@vger.kernel.org,
Kirill Marinushkin <k.marinushkin@gmail.com>
Subject: Re: [alsa-devel] Applied "ASoC: topology: Fix logical inversion in set_link_hw_format()" to the asoc tree
Date: Tue, 27 Feb 2018 22:22:08 -0800 [thread overview]
Message-ID: <d1343157-c310-78e3-1709-2f5baaa5e27c@linux.intel.com> (raw)
In-Reply-To: <20180227155758.GD11822@sirena.org.uk>
On 2/27/18 7:57 AM, Mark Brown wrote:
> On Tue, Feb 27, 2018 at 07:13:17AM -0800, Pierre-Louis Bossart wrote:
>> On 2/27/18 2:38 AM, Mark Brown wrote:
>>> On Mon, Feb 26, 2018 at 06:30:15PM -0800, Pierre-Louis Bossart wrote:
>
>>>> This issue was found during the development of SOF (Sound Open Firmware)
>>>> where we get the reverse of the intended behavior when using the same
>>>> conventions in topology files as in machine drivers.
>
>>> Is this perhaps something that the earlier firmware is handling inside
>>> the firmware?
>
>> For SKL+ the SSP settings come from binary blobs read from ACPI/NHLT tables
>> so I am wondering if this inversion is compensated for in the tools used to
>> generate the blobs.
>
> Ugh, I'm confused here. Is this a case of SoF differing from the
> regular firmware somehow - presumably the stuff coming from the NHLT
> table is the same for both firmwares?
no we are not using the NHLT info for now but using the one provided in
topology files. the SOF firmware does not rely on blobs but programs the
registers based on masks and settings passed. This difference is
precisely how we exposed a difference in behavior.
next prev parent reply other threads:[~2018-02-28 6:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1519336888-71831-1-git-send-email-xiuli.pan@linux.intel.com>
2018-02-26 11:17 ` Applied "ASoC: topology: Fix logical inversion in set_link_hw_format()" to the asoc tree Mark Brown
2018-02-26 18:34 ` Kirill Marinushkin
2018-02-26 19:47 ` Mark Brown
2018-02-27 4:38 ` Kirill Marinushkin
2018-02-27 2:30 ` [alsa-devel] " Pierre-Louis Bossart
2018-02-27 4:50 ` Kirill Marinushkin
2018-02-27 10:38 ` Mark Brown
2018-02-27 15:13 ` Pierre-Louis Bossart
2018-02-27 15:57 ` Mark Brown
2018-02-28 6:22 ` Pierre-Louis Bossart [this message]
2018-03-12 16:14 ` Mark Brown
2018-03-12 23:29 ` [alsa-devel] " Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1343157-c310-78e3-1709-2f5baaa5e27c@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=k.marinushkin@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=xiuli.pan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox