From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DFF78405F for ; Thu, 23 May 2024 20:40:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716496832; cv=none; b=sPCZ0S/V441FO8oYpl1cxUjvue+gSusLHfecRcXLXU9HXdwsiwnzBt/ghScd5TVWhbThDIemnAaHuF33sUDvsRo7+Lp/j97gtnMxfNmpxq7QuRMsV8TNlkAmMgNEqydE5phLvBpe23Px02tvhkiQuZqBnALM0fEPS8RAvvXJYMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716496832; c=relaxed/simple; bh=ltO5em4AVQnYhKAyiqcASG2EnbQQabcM2h0UzoDpUeI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RYJ8uuTj370fTC0vSTpbYBbYpkNU2K0veAN6iCkflIyVAi2oXtYzoqPOeuRMdEcolSuirp3bn8/X0+rcpk1WckAo3O3IyLj01yq02H40JRoF3o9rRa/GjzEwLTEo37tuDITOMnekiaF4MpaYXiFK02yNmGvTz/hsWcfWVQRm8qc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ENHvKpTL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ENHvKpTL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716496830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HMRwhM4rpgDOdhtnbcfTstE8zL3QawjuI32cVW7/W+w=; b=ENHvKpTLd0bouzPVkZIYjYu4+jFmt4WnWQqiEeCXcXHGCsAYcJfRw+5FsPn0oGI83CL+ga lNd9EHqfg6wNX+yr3PEyuleD1gIBxeeoRnbx9Ah+LnRoTr5c1SUM9qatgKOVSJOmkm9zIu AX3j15klDOcYhbnx4QdsFLa0mftc8sc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-1NicqsM2O_-HZGQUq-GsUQ-1; Thu, 23 May 2024 16:40:29 -0400 X-MC-Unique: 1NicqsM2O_-HZGQUq-GsUQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-35559d305e3so25024f8f.2 for ; Thu, 23 May 2024 13:40:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716496828; x=1717101628; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HMRwhM4rpgDOdhtnbcfTstE8zL3QawjuI32cVW7/W+w=; b=TQnUA677N9mRFPBsQSk+S3PLIEH4WqjACa/hUW8EGavwfUvhPP6dxof5kk366mjAJl 8gH3Qok+HtjTzolcCYGvuQ1Dk3Y68059gJbXoew7SuAOIUcHwJtPBhyecGCH/SvcQ0Ae vuaK/ZHacBgKaWEzFAGEpgSijjnmOjcNCDZAjJykww5S54j9GLiT6eEItd5fAKZcO0JS OVuZHtR7uYA7Yt1hy/6z1veA5JCLFtvcdBWsq6Kc8gzCUrFyRa1YGAj1I0FkAUfUqfKA 5b4EocQZpyxwC9WGViZqiqAPmtXyxuvLud8XTP+HSFOEFue+w1um6KZeDgfYUx/Z9Nbk rRAQ== X-Forwarded-Encrypted: i=1; AJvYcCW1Z/iTa2hMKlWpPTh72Gai8MZJ7BtqUSk9OQiqLVIDDJQx1YKUfp11GK+DtFo+uR+F1FOmm1CjdOram1zKQx6hZ9elU3wC X-Gm-Message-State: AOJu0YwmW7eIR6w3v7MWz2l1c1+OR7V4vY1hwj8D06dmJq65G3iDSlIn E7JSnRd6axD/zQOgjtYh+3unPB8QCIoUovsW00Aegwprlp69TR+38h5XrKDL/5L0BNw2IMuFM6d dnD94yecGPLoUOhgEXt2LTNbEvRVdH+VGe1Td8b+mu4C39fFxSQl7gA== X-Received: by 2002:adf:f183:0:b0:354:f5f2:198b with SMTP id ffacd0b85a97d-3552fdc828bmr88014f8f.46.1716496827854; Thu, 23 May 2024 13:40:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIlHlYs/IzRViA3Kqxz4toDkVk96XetDA5NIaYKisMefLa6AGLghVkkUDvpvwpKUhwSEnXaA== X-Received: by 2002:adf:f183:0:b0:354:f5f2:198b with SMTP id ffacd0b85a97d-3552fdc828bmr88004f8f.46.1716496827449; Thu, 23 May 2024 13:40:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c717:5f00:c949:6700:cce1:e60b? (p200300cbc7175f00c9496700cce1e60b.dip0.t-ipconnect.de. [2003:cb:c717:5f00:c949:6700:cce1:e60b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-355049af3d9sm514554f8f.76.2024.05.23.13.40.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 May 2024 13:40:27 -0700 (PDT) Message-ID: Date: Thu, 23 May 2024 22:40:25 +0200 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftest: mm: Test if hugepage does not get leaked during __bio_release_pages() To: Andrew Morton , Donet Tom Cc: Shuah Khan , Matthew Wilcox , Tony Battersby , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Mike Rapoport , Muchun Song , stable@vger.kernel.org References: <20240523063905.3173-1-donettom@linux.ibm.com> <20240523121344.6a67a109e0af2ba70973b34b@linux-foundation.org> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240523121344.6a67a109e0af2ba70973b34b@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23.05.24 21:13, Andrew Morton wrote: > On Thu, 23 May 2024 01:39:05 -0500 Donet Tom wrote: > >> Commit 1b151e2435fc ("block: Remove special-casing of compound >> pages") caused a change in behaviour when releasing the pages >> if the buffer does not start at the beginning of the page. This >> was because the calculation of the number of pages to release >> was incorrect. >> This was fixed by commit 38b43539d64b ("block: Fix page refcounts >> for unaligned buffers in __bio_release_pages()"). >> >> We pin the user buffer during direct I/O writes. If this buffer is a >> hugepage, bio_release_page() will unpin it and decrement all references >> and pin counts at ->bi_end_io. However, if any references to the hugepage >> remain post-I/O, the hugepage will not be freed upon unmap, leading >> to a memory leak. >> >> This patch verifies that a hugepage, used as a user buffer for DIO >> operations, is correctly freed upon unmapping, regardless of whether >> the offsets are aligned or unaligned w.r.t page boundary. >> > Two SOF, is there a Co-developed-by: missing? > You have stable@vger.kernel.org in the mail headers, so I assume you're > proposing this for backporting. When doing this, please include > > Cc: > > in the changelog footers and also include a Fixes: target. I'm > assuming the suitable Fixes: target for this patch is 38b43539d64b? This adds a new selfest to make sure what was fixed (and backported to stable) remains fixed. -- Cheers, David / dhildenb