From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AF3F4317E for ; Fri, 10 May 2024 19:49:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715370580; cv=none; b=tkenhh7cy7p1hWR1MYZa1KJIbjEMkYAVHlHB1d7RbZeSe1GW5byYRPtseYoPHUFk5ONaAHIl94FJ9frhX7YZfKJZxKAoLXUhbKI/ikdLVr4bMuTHYym1TfTa4HyF0wCivCnhtaFbqk8o3xvRtwMfeHrKFYfqqE8XkmSxo2ZsW84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715370580; c=relaxed/simple; bh=JCFFmbNlsOn6FVvGztjgo6+wDYo3/QMxgC04ADQpeJY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=keq0fRRpj40tAqPAVosqskn4Pw+innYqDetIczyl7tuh9Luux+iPBlLZJPwXrlr/CS6s5rtf9m8DXO+BqZjmMYOzk1r5c7paheWZJDo6mGpcvflakIafj4/QhaqDq+Wz6x8GHr+5jAPODUDGgkV2ktBJohCoR2W8x9eaozNX/ss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=penguintechs.org; spf=pass smtp.mailfrom=penguintechs.org; dkim=pass (1024-bit key) header.d=penguintechs.org header.i=@penguintechs.org header.b=YZgESg6e; arc=none smtp.client-ip=209.85.161.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=penguintechs.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=penguintechs.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=penguintechs.org header.i=@penguintechs.org header.b="YZgESg6e" Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5b277993a48so1195101eaf.1 for ; Fri, 10 May 2024 12:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=penguintechs.org; s=google; t=1715370576; x=1715975376; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yxWyXszhHGNezoVa9cm6qt9auwsbCofn2LFU7/T+05M=; b=YZgESg6eBrMAaoeIa+C1eu2czx+4a0b2iF2AllDctx5CvMew/giAm1H+eyQ2Im9nzl etaqrtAMU1wL1K5fPwQyhu+FswUv5dgpdbkb48AIfVOP8x4q/96e9C/37ji7vj/mVLdL 3k7deKhuwRwVByM2p3tLqVAJ58EawYjIrJ3cs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715370576; x=1715975376; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yxWyXszhHGNezoVa9cm6qt9auwsbCofn2LFU7/T+05M=; b=QS/I8B4Pfn4tFIl9SP+fYBJHemu4GCuwbncTL1/gj7MurkUyxApfkL46cY7t3KUwKw CZD5OmV8PzPvmnKfR0SUrpnsPo9QqnlLvNwAxgMn14nB7RewdoQRc/dILUY1wLl7FQ9t t1f2yZRfX7NWuFqhFOgxTOb8Vya1lmS6I1lAXrVgFdaBh/CucUCweVXTjlH3KBjo8MkC MjNeDUoUAv6l8xAcFDz2b4lZuqvRtOc7dcdKpYjQR8z0/DYfVAxZsp+VZFlyVYxYZTXG 7HIunDYE33WqkJw8HyaKxWBwfZAjN4V7csDV1ZUgZIO8BXSLQWpKYXYgsfQP9mvpAF0h oBKQ== X-Forwarded-Encrypted: i=1; AJvYcCVu2WF+nQTTk0O7PhjE5IYgtanpVTkjKoUbmvil24CHud3fEG7eDxlex4fPDhuHTSw3fJP+wnJQOKFyYPTQBoJLRG4VTuwf X-Gm-Message-State: AOJu0Yws+RTsozBbq46fZi+w3f4f0xx4KotzjGcsGVjzxVUtVPN5u1Pf 7KnSw2Lk1hd/0FTYDVQlmjAHggIiDjJU+mePGYZRKcM/jLmhyW2Jcl2TjyocvQ== X-Google-Smtp-Source: AGHT+IEX+36Sj6GYkUunsowtfhH38q+3cvxoAjNx4PliHhEkHO5WeF7xTXdWc4kLq9JBMqeDbGP8yg== X-Received: by 2002:a05:6358:93a3:b0:192:9d35:b025 with SMTP id e5c5f4694b2df-193bb63f056mr351397055d.16.1715370576521; Fri, 10 May 2024 12:49:36 -0700 (PDT) Received: from ?IPV6:2601:646:8700:dd30:5f3e:5ba7:e0ea:9a08? ([2601:646:8700:dd30:5f3e:5ba7:e0ea:9a08]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6340c4d4a1csm3462978a12.40.2024.05.10.12.49.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 May 2024 12:49:36 -0700 (PDT) Message-ID: Date: Fri, 10 May 2024 12:49:34 -0700 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] Bluetooth: qca: Fix BT enable failure again for QCA6390 after warm reboot Content-Language: en-US To: Krzysztof Kozlowski , Zijun Hu , luiz.dentz@gmail.com, luiz.von.dentz@intel.com, marcel@holtmann.org Cc: linux-bluetooth@vger.kernel.org, regressions@lists.linux.dev, stable@vger.kernel.org References: <1714658761-15326-1-git-send-email-quic_zijuhu@quicinc.com> <5e5e869c-da12-4818-837e-55709f0c4db9@kernel.org> From: Wren Turkal In-Reply-To: <5e5e869c-da12-4818-837e-55709f0c4db9@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/3/24 3:16 AM, Krzysztof Kozlowski wrote: > On 02/05/2024 16:06, Zijun Hu wrote: >> Commit 272970be3dab ("Bluetooth: hci_qca: Fix driver shutdown on closed >> serdev") will cause below regression issue: >> >> BT can't be enabled after below steps: >> cold boot -> enable BT -> disable BT -> warm reboot -> BT enable failure >> if property enable-gpios is not configured within DT|ACPI for QCA6390. >> >> The commit is to fix a use-after-free issue within qca_serdev_shutdown() >> during reboot, but also introduces this regression issue regarding above >> steps since the VSC is not sent to reset controller during warm reboot. >> >> Fixed by sending the VSC to reset controller within qca_serdev_shutdown() >> once BT was ever enabled, and the use-after-free issue is also be fixed >> by this change since serdev is still opened when send to serdev. >> >> Fixes: 272970be3dab ("Bluetooth: hci_qca: Fix driver shutdown on closed serdev") >> Cc: stable@vger.kernel.org >> Reported-by: Wren Turkal >> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218726 >> Signed-off-by: Zijun Hu >> Tested-by: Wren Turkal >> --- >> drivers/bluetooth/hci_qca.c | 5 ++--- > > I don't think this is v1. Version your patches properly and provide > changelog. > > I asked already *two times*: > 1. On which kernel did you test it? > 2. On which hardware did you test it? I thought I had already chimed in with this information. I am using a Dell XPS 13 9310. It's the only hardware I have access to. I can say that the fix seems to work as advertised in that it fixes the warm boot issue I have been experiencing. As a user, I vastly prefer a one time cold boot rather than having to do it every time. As such, I can do the test. However, I do not think that the patch not working in that case should block landing logic that empirically improved my experience with the hardware and minimizes the corner case to a much smaller corner (that of warm booting from an OS that improperly puts the device in a bad state to a Linux kernel with this UX improvement). wt -- You're more amazing than you think!