From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Dikshita Agarwal <quic_dikshita@quicinc.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Stefan Schmidt <stefan.schmidt@linaro.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v4 01/25] media: iris: Skip destroying internal buffer if not dequeued
Date: Wed, 7 May 2025 16:07:12 +0100 [thread overview]
Message-ID: <dae06ff6-afd9-46a4-bd37-25bb367ba545@linaro.org> (raw)
In-Reply-To: <20250507-video-iris-hevc-vp9-v4-1-58db3660ac61@quicinc.com>
On 07/05/2025 08:39, Dikshita Agarwal wrote:
> Firmware might hold the DPB buffers for reference in case of sequence
> change, so skip destroying buffers for which QUEUED flag is not removed.
> Also, make sure that all buffers are released during streamoff.
>
> Cc: stable@vger.kernel.org
> Fixes: 73702f45db81 ("media: iris: allocate, initialize and queue internal buffers")
> Reviewed-by: Vikash Garodia <quic_vgarodia@quicinc.com>
> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
I'll take your word for it on firmware respecting the software contract
on close() wrt to DMA - however I think you should split this patch into
two separate patches along the lines of the "also" in your commit log.
1. Skip destroying buffers for QUEUED flag
2. Make sure all buffers are released during stream off
These are two separate fixes IMO.
---
bod
next prev parent reply other threads:[~2025-05-07 15:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 7:39 [PATCH v4 00/25] Add support for HEVC and VP9 codecs in decoder Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 01/25] media: iris: Skip destroying internal buffer if not dequeued Dikshita Agarwal
2025-05-07 15:07 ` Bryan O'Donoghue [this message]
2025-05-08 10:29 ` Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 02/25] media: iris: Update CAPTURE format info based on OUTPUT format Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 03/25] media: iris: Avoid updating frame size to firmware during reconfig Dikshita Agarwal
2025-05-07 15:09 ` Bryan O'Donoghue
2025-05-07 7:39 ` [PATCH v4 04/25] media: iris: Drop port check for session property response Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 05/25] media: iris: Prevent HFI queue writes when core is in deinit state Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 06/25] media: iris: Remove error check for non-zero v4l2 controls Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 07/25] media: iris: Remove deprecated property setting to firmware Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 08/25] media: iris: Fix missing function pointer initialization Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 09/25] media: iris: Fix NULL pointer dereference Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 10/25] media: iris: Fix typo in depth variable Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 11/25] media: iris: Track flush responses to prevent premature completion Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 12/25] media: iris: Fix buffer preparation failure during resolution change Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 13/25] media: iris: Send V4L2_BUF_FLAG_ERROR for capture buffers with 0 filled length Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 14/25] media: iris: Skip flush on first sequence change Dikshita Agarwal
2025-05-07 7:39 ` [PATCH v4 15/25] media: iris: Remove unnecessary re-initialization of flush completion Dikshita Agarwal
2025-05-07 8:46 ` [PATCH v4 00/25] Add support for HEVC and VP9 codecs in decoder Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dae06ff6-afd9-46a4-bd37-25bb367ba545@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=dan.carpenter@linaro.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.dufresne@collabora.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=stefan.schmidt@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox