public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: sergei.shtylyov@gmail.com, dlemoal@kernel.org,
	linux-ide@vger.kernel.org, linux-m68k@vger.kernel.org,
	will@sowerbutts.com, rz@linux-m68k.org, stable@vger.kernel.org,
	Finn Thain <fthain@linux-m68k.org>
Subject: Re: [PATCH v4 1/2] ata: pata_falcon: fix IO base selection for Q40
Date: Thu, 24 Aug 2023 13:54:02 +1200	[thread overview]
Message-ID: <dc4ddd28-d3cd-9816-44d5-450efb9e7246@gmail.com> (raw)
In-Reply-To: <CAMuHMdUcFprFuwyfvRdKeyvjVAG6hre9S+hU1FvoM69d9_qR-w@mail.gmail.com>

Hi Geert,

On 23/08/23 21:05, Geert Uytterhoeven wrote:
>
> Thanks for the update!
>
>> --- a/drivers/ata/pata_falcon.c
>> +++ b/drivers/ata/pata_falcon.c
>> +       ata_port_desc(ap, "cmd %px ctl %px data %pa",
>> +                     base, ctl_base, &ap->ioaddr.data_addr);
> %px and ap->ioaddr.data_addr
>
> The rest LGTM, so with the above fixed
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Will fix this in v4.

Thanks,

     Michael

>
> Gr{oetje,eeting}s,
>
>                          Geert
>

  reply	other threads:[~2023-08-24  1:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230822221359.31024-1-schmitzmic@gmail.com>
2023-08-22 22:13 ` [PATCH v4 1/2] ata: pata_falcon: fix IO base selection for Q40 Michael Schmitz
2023-08-23  9:05   ` Geert Uytterhoeven
2023-08-24  1:54     ` Michael Schmitz [this message]
2023-08-23 16:05   ` Sergey Shtylyov
2023-08-24  1:56     ` Michael Schmitz
2023-08-24 10:00       ` Sergey Shtylyov
2023-08-25  1:07         ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc4ddd28-d3cd-9816-44d5-450efb9e7246@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=dlemoal@kernel.org \
    --cc=fthain@linux-m68k.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=rz@linux-m68k.org \
    --cc=sergei.shtylyov@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=will@sowerbutts.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox