From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.mailbox.org ([80.241.60.212]:52393 "EHLO mx1.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbdKSLza (ORCPT ); Sun, 19 Nov 2017 06:55:30 -0500 Subject: Re: 4.9.62: intermittent flicker after upgrade from 4.9.61 To: Greg KH Cc: stable@vger.kernel.org References: <20171118125100.GA32744@kroah.com> <20171119100712.GA25266@kroah.com> From: Rainer Fiebig Message-ID: Date: Sun, 19 Nov 2017 12:56:26 +0100 MIME-Version: 1.0 In-Reply-To: <20171119100712.GA25266@kroah.com> Content-Type: multipart/mixed; boundary="------------48F059C1593B4CF71661FDDC" Sender: stable-owner@vger.kernel.org List-ID: This is a multi-part message in MIME format. --------------48F059C1593B4CF71661FDDC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Greg KH wrote: > On Sat, Nov 18, 2017 at 05:08:20PM +0100, Rainer Fiebig wrote: >> Greg KH wrote: >>> On Sat, Nov 18, 2017 at 01:47:32PM +0100, Rainer Fiebig wrote: >>>> Hi! >>>> >>>> Hopefully the right addressee. >>>> >>>> Encountered two bad backports which cause screen-flicker. >>>> dmesg shows: >>>> >>>> ... >>>> [drm:ironlake_irq_handler [i915]] *ERROR* CPU pipe A FIFO underrun >>>> [drm:ironlake_irq_handler [i915]] *ERROR* PCH transcoder A FIFO underrun >>>> [drm:ironlake_irq_handler [i915]] *ERROR* CPU pipe B FIFO underrun >>>> [drm:ironlake_irq_handler [i915]] *ERROR* PCH transcoder B FIFO underrun >>>> ... >>>> >>>> CPU: Intel Core i3 (Clarkdale/Ironlake) >>>> >>>> The backports are: >>>> >>>> - diff --git a/drivers/gpu/drm/i915/intel_pm.c >>>> b/drivers/gpu/drm/i915/intel_pm.c >>>> index 49de476..277a802 100644 >>>> - diff --git a/drivers/gpu/drm/i915/intel_drv.h >>>> b/drivers/gpu/drm/i915/intel_drv.h >>>> index a19ec06..3ce9ba3 100644 >>>> >>>> After reversing them the flicker is gone, no more messages in dmesg. All >>>> else OK so far. >>> >>> So which commit was the one that caused the problem? I will be glad to >>> revert it. >>> >>> thanks, >>> >>> greg k-h >>> >>> >> >> I started by reverting the more complex one first ("index >> 49de476..277a802100644"). But the kernel wouldn't compile then. > > What git commit id is that? I don't see those ids in the 4.9-stable > tree. > >> So I also reverted "index a19ec06..3ce9ba3 100644". After that the >> kernel compiled just fine and the problems were gone (still are). > > Same here, what git commit id was this? > > thanks, > > greg k-h > OK, no mistake. IIRC, I took the patches (and the IDs) from the changelog for patch-4.9.62. I've attached both, so you can check yourself. I've also applied a freshly downloaded patch-4.9.62 to a freshly expanded 4.9 and re-compiled. The flicker is there. I haven't yet reverted the two patches but I'm confident that after having done so the flicker will be gone. If not I'll let you know. As a good news: 4.14 is *not* affected. So to me it seems those two patches are part of sort of a package and can not be backported alone. So long! Rainer Fiebig --------------48F059C1593B4CF71661FDDC Content-Type: text/plain; charset=UTF-8; name="patch-4.9.62_49de476" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch-4.9.62_49de476" ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCmluZGV4IDQ5ZGU0NzYuLjI3N2E4MDIgMTAwNjQ0 Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcG0uYwpAQCAtMjcsNiArMjcsNyBAQAogCiAjaW5jbHVkZSA8 bGludXgvY3B1ZnJlcS5oPgogI2luY2x1ZGUgPGRybS9kcm1fcGxhbmVfaGVscGVyLmg+Cisj aW5jbHVkZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+CiAjaW5jbHVkZSAiaTkxNV9kcnYu aCIKICNpbmNsdWRlICJpbnRlbF9kcnYuaCIKICNpbmNsdWRlICIuLi8uLi8uLi9wbGF0Zm9y bS94ODYvaW50ZWxfaXBzLmgiCkBAIC0yMDE3LDkgKzIwMTgsOSBAQCBzdGF0aWMgdm9pZCBp bGtfY29tcHV0ZV93bV9sZXZlbChjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCiAJCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAogCQkJ CSBpbnQgbGV2ZWwsCiAJCQkJIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCi0J CQkJIHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcHJpc3RhdGUsCi0JCQkJIHN0cnVjdCBp bnRlbF9wbGFuZV9zdGF0ZSAqc3Byc3RhdGUsCi0JCQkJIHN0cnVjdCBpbnRlbF9wbGFuZV9z dGF0ZSAqY3Vyc3RhdGUsCisJCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAq cHJpc3RhdGUsCisJCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqc3Byc3Rh dGUsCisJCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqY3Vyc3RhdGUsCiAJ CQkJIHN0cnVjdCBpbnRlbF93bV9sZXZlbCAqcmVzdWx0KQogewogCXVpbnQxNl90IHByaV9s YXRlbmN5ID0gZGV2X3ByaXYtPndtLnByaV9sYXRlbmN5W2xldmVsXTsKQEAgLTIzNDEsMjgg KzIzNDIsMjQgQEAgc3RhdGljIGludCBpbGtfY29tcHV0ZV9waXBlX3dtKHN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpjc3RhdGUpCiAJc3RydWN0IGludGVsX3BpcGVfd20gKnBpcGVfd207 CiAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHN0YXRlLT5kZXY7CiAJY29uc3Qgc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwotCXN0cnVjdCBp bnRlbF9wbGFuZSAqaW50ZWxfcGxhbmU7Ci0Jc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpw cmlzdGF0ZSA9IE5VTEw7Ci0Jc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpzcHJzdGF0ZSA9 IE5VTEw7Ci0Jc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpjdXJzdGF0ZSA9IE5VTEw7CisJ c3RydWN0IGRybV9wbGFuZSAqcGxhbmU7CisJY29uc3Qgc3RydWN0IGRybV9wbGFuZV9zdGF0 ZSAqcGxhbmVfc3RhdGU7CisJY29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwcmlz dGF0ZSA9IE5VTEw7CisJY29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpzcHJzdGF0 ZSA9IE5VTEw7CisJY29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpjdXJzdGF0ZSA9 IE5VTEw7CiAJaW50IGxldmVsLCBtYXhfbGV2ZWwgPSBpbGtfd21fbWF4X2xldmVsKGRldiks IHVzYWJsZV9sZXZlbDsKIAlzdHJ1Y3QgaWxrX3dtX21heGltdW1zIG1heDsKIAogCXBpcGVf d20gPSAmY3N0YXRlLT53bS5pbGsub3B0aW1hbDsKIAotCWZvcl9lYWNoX2ludGVsX3BsYW5l X29uX2NydGMoZGV2LCBpbnRlbF9jcnRjLCBpbnRlbF9wbGFuZSkgewotCQlzdHJ1Y3QgaW50 ZWxfcGxhbmVfc3RhdGUgKnBzOworCWRybV9hdG9taWNfY3J0Y19zdGF0ZV9mb3JfZWFjaF9w bGFuZV9zdGF0ZShwbGFuZSwgcGxhbmVfc3RhdGUsICZjc3RhdGUtPmJhc2UpIHsKKwkJY29u c3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwcyA9IHRvX2ludGVsX3BsYW5lX3N0YXRl KHBsYW5lX3N0YXRlKTsKIAotCQlwcyA9IGludGVsX2F0b21pY19nZXRfZXhpc3RpbmdfcGxh bmVfc3RhdGUoc3RhdGUsCi0JCQkJCQkJICAgaW50ZWxfcGxhbmUpOwotCQlpZiAoIXBzKQot CQkJY29udGludWU7Ci0KLQkJaWYgKGludGVsX3BsYW5lLT5iYXNlLnR5cGUgPT0gRFJNX1BM QU5FX1RZUEVfUFJJTUFSWSkKKwkJaWYgKHBsYW5lLT50eXBlID09IERSTV9QTEFORV9UWVBF X1BSSU1BUlkpCiAJCQlwcmlzdGF0ZSA9IHBzOwotCQllbHNlIGlmIChpbnRlbF9wbGFuZS0+ YmFzZS50eXBlID09IERSTV9QTEFORV9UWVBFX09WRVJMQVkpCisJCWVsc2UgaWYgKHBsYW5l LT50eXBlID09IERSTV9QTEFORV9UWVBFX09WRVJMQVkpCiAJCQlzcHJzdGF0ZSA9IHBzOwot CQllbHNlIGlmIChpbnRlbF9wbGFuZS0+YmFzZS50eXBlID09IERSTV9QTEFORV9UWVBFX0NV UlNPUikKKwkJZWxzZSBpZiAocGxhbmUtPnR5cGUgPT0gRFJNX1BMQU5FX1RZUEVfQ1VSU09S KQogCQkJY3Vyc3RhdGUgPSBwczsKIAl9CiAKQEAgLTIzODQsMTEgKzIzODEsOSBAQCBzdGF0 aWMgaW50IGlsa19jb21wdXRlX3BpcGVfd20oc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNz dGF0ZSkKIAlpZiAocGlwZV93bS0+c3ByaXRlc19zY2FsZWQpCiAJCXVzYWJsZV9sZXZlbCA9 IDA7CiAKLQlpbGtfY29tcHV0ZV93bV9sZXZlbChkZXZfcHJpdiwgaW50ZWxfY3J0YywgMCwg Y3N0YXRlLAotCQkJICAgICBwcmlzdGF0ZSwgc3Byc3RhdGUsIGN1cnN0YXRlLCAmcGlwZV93 bS0+cmF3X3dtWzBdKTsKLQogCW1lbXNldCgmcGlwZV93bS0+d20sIDAsIHNpemVvZihwaXBl X3dtLT53bSkpOwotCXBpcGVfd20tPndtWzBdID0gcGlwZV93bS0+cmF3X3dtWzBdOworCWls a19jb21wdXRlX3dtX2xldmVsKGRldl9wcml2LCBpbnRlbF9jcnRjLCAwLCBjc3RhdGUsCisJ CQkgICAgIHByaXN0YXRlLCBzcHJzdGF0ZSwgY3Vyc3RhdGUsICZwaXBlX3dtLT53bVswXSk7 CiAKIAlpZiAoSVNfSEFTV0VMTChkZXYpIHx8IElTX0JST0FEV0VMTChkZXYpKQogCQlwaXBl X3dtLT5saW5ldGltZSA9IGhzd19jb21wdXRlX2xpbmV0aW1lX3dtKGNzdGF0ZSk7CkBAIC0y Mzk4LDggKzIzOTMsOCBAQCBzdGF0aWMgaW50IGlsa19jb21wdXRlX3BpcGVfd20oc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZSkKIAogCWlsa19jb21wdXRlX3dtX3JlZ19tYXhp bXVtcyhkZXYsIDEsICZtYXgpOwogCi0JZm9yIChsZXZlbCA9IDE7IGxldmVsIDw9IG1heF9s ZXZlbDsgbGV2ZWwrKykgewotCQlzdHJ1Y3QgaW50ZWxfd21fbGV2ZWwgKndtID0gJnBpcGVf d20tPnJhd193bVtsZXZlbF07CisJZm9yIChsZXZlbCA9IDE7IGxldmVsIDw9IHVzYWJsZV9s ZXZlbDsgbGV2ZWwrKykgeworCQlzdHJ1Y3QgaW50ZWxfd21fbGV2ZWwgKndtID0gJnBpcGVf d20tPndtW2xldmVsXTsKIAogCQlpbGtfY29tcHV0ZV93bV9sZXZlbChkZXZfcHJpdiwgaW50 ZWxfY3J0YywgbGV2ZWwsIGNzdGF0ZSwKIAkJCQkgICAgIHByaXN0YXRlLCBzcHJzdGF0ZSwg Y3Vyc3RhdGUsIHdtKTsKQEAgLTI0MDksMTMgKzI0MDQsMTAgQEAgc3RhdGljIGludCBpbGtf Y29tcHV0ZV9waXBlX3dtKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUpCiAJCSAq IHJlZ2lzdGVyIG1heGltdW1zIHNpbmNlIHN1Y2ggd2F0ZXJtYXJrcyBhcmUKIAkJICogYWx3 YXlzIGludmFsaWQuCiAJCSAqLwotCQlpZiAobGV2ZWwgPiB1c2FibGVfbGV2ZWwpCi0JCQlj b250aW51ZTsKLQotCQlpZiAoaWxrX3ZhbGlkYXRlX3dtX2xldmVsKGxldmVsLCAmbWF4LCB3 bSkpCi0JCQlwaXBlX3dtLT53bVtsZXZlbF0gPSAqd207Ci0JCWVsc2UKLQkJCXVzYWJsZV9s ZXZlbCA9IGxldmVsOworCQlpZiAoIWlsa192YWxpZGF0ZV93bV9sZXZlbChsZXZlbCwgJm1h eCwgd20pKSB7CisJCQltZW1zZXQod20sIDAsIHNpemVvZigqd20pKTsKKwkJCWJyZWFrOwor CQl9CiAJfQogCiAJcmV0dXJuIDA7Cg== --------------48F059C1593B4CF71661FDDC Content-Type: text/plain; charset=UTF-8; name="patch-4.9.62_a19ec06" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch-4.9.62_a19ec06" ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKaW5kZXggYTE5ZWMwNi4uM2NlOWJhMyAxMDA2 NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKQEAgLTQ1Nyw3ICs0NTcsNiBAQCBzdHJ1Y3Qg aW50ZWxfY3J0Y19zY2FsZXJfc3RhdGUgewogCiBzdHJ1Y3QgaW50ZWxfcGlwZV93bSB7CiAJ c3RydWN0IGludGVsX3dtX2xldmVsIHdtWzVdOwotCXN0cnVjdCBpbnRlbF93bV9sZXZlbCBy YXdfd21bNV07CiAJdWludDMyX3QgbGluZXRpbWU7CiAJYm9vbCBmYmNfd21fZW5hYmxlZDsK IAlib29sIHBpcGVfZW5hYmxlZDsK --------------48F059C1593B4CF71661FDDC--