From: Markus Elfring <Markus.Elfring@web.de>
To: Louis Chauvet <louis.chauvet@bootlin.com>,
Lizhi Hou <lizhi.hou@amd.com>, Brian Xu <brian.xu@amd.com>,
Raj Kumar Rampelli <raj.kumar.rampelli@amd.com>,
Vinod Koul <vkoul@kernel.org>,
Michal Simek <michal.simek@amd.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: xilinx: xdma: Fix data synchronisation in xdma_channel_isr()
Date: Fri, 7 Jun 2024 13:00:20 +0200 [thread overview]
Message-ID: <dd01cc26-5af5-45f6-a5b0-b5d29da3f01e@web.de> (raw)
In-Reply-To: <20240607-xdma-fixes-v2-1-0282319ce345@bootlin.com>
> Requests the vchan lock before using xdma->stop_request.
Better wording alternative?:
A data synchronisation construct was missing in this function implementation.
Thus apply the vchan lock before checking the data structure
member “xchan->stop_requested”.
> ---
> drivers/dma/xilinx/xdma.c | 4 ++--
How do think about to avoid a duplicate marker line?
…
> +++ b/drivers/dma/xilinx/xdma.c
> @@ -885,11 +885,11 @@ static irqreturn_t xdma_channel_isr(int irq, void *dev_id)
> u32 st;
> bool repeat_tx;
>
> + spin_lock(&xchan->vchan.lock);
> +
> if (xchan->stop_requested)
> complete(&xchan->last_interrupt);
>
> - spin_lock(&xchan->vchan.lock);
> -
> /* get submitted request */
…
Under which circumstances will development interests grow for the usage of
a statement like “guard(raw_spinlock)(&xchan->vchan.lock);”?
https://elixir.bootlin.com/linux/v6.10-rc2/source/include/linux/cleanup.h#L124
Regards,
Markus
next prev parent reply other threads:[~2024-06-07 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 8:34 [PATCH v2] dmaengine: xilinx: xdma: Fix data synchronisation in xdma_channel_isr() Louis Chauvet
2024-06-07 11:00 ` Markus Elfring [this message]
2024-06-07 12:23 ` Markus Elfring
2024-06-07 17:47 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd01cc26-5af5-45f6-a5b0-b5d29da3f01e@web.de \
--to=markus.elfring@web.de \
--cc=brian.xu@amd.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=louis.chauvet@bootlin.com \
--cc=michal.simek@amd.com \
--cc=raj.kumar.rampelli@amd.com \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox