From: isaacm@codeaurora.org
To: Peter Zijlstra <peterz@infradead.org>
Cc: matt@codeblueprint.co.uk, mingo@kernel.org, tglx@linutronix.de,
bigeasy@linutronix.de, linux-kernel@vger.kernel.org,
psodagud@codeaurora.org, gregkh@linuxfoundation.org,
pkondeti@codeaurora.org, stable@vger.kernel.org
Subject: Re: [PATCH v4] stop_machine: Disable preemption after queueing stopper threads
Date: Tue, 17 Jul 2018 12:34:34 -0700 [thread overview]
Message-ID: <df84aa9229cf0789fd4f729b06161be9@codeaurora.org> (raw)
In-Reply-To: <20180717183450.GL2494@hirez.programming.kicks-ass.net>
Alright, we will make a new patch for this. Thanks for the feedback.
Thanks,
Isaac Manjarres
On 2018-07-17 11:34, Peter Zijlstra wrote:
> On Tue, Jul 17, 2018 at 09:30:17AM -0700, Isaac J. Manjarres wrote:
>> After cpu_stop_queue_two_works() queues the cpu_stop works
>> for the stopper threads, it releases the locks held for
>> both threads, which enables preemption, which allows the
>> following race condition to occur:
>
>
> Does not apply because an earlier version is already applied.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/kernel/stop_machine.c?id=9fb8d5dc4b649dd190e1af4ead670753e71bf907
>
> if there still is a problem, please send a new patch that describes the
> remaining problem.
prev parent reply other threads:[~2018-07-17 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 16:30 [PATCH v4] stop_machine: Disable preemption after queueing stopper threads Isaac J. Manjarres
2018-07-17 18:34 ` Peter Zijlstra
2018-07-17 19:34 ` isaacm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df84aa9229cf0789fd4f729b06161be9@codeaurora.org \
--to=isaacm@codeaurora.org \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pkondeti@codeaurora.org \
--cc=psodagud@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).